Fix for 1274 - Fixing publish option for template provisioning extraction - #1275
Open
Magnus-K-work wants to merge 1 commit into
Open
Conversation
… extracted as Published or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue:
#1274 - Provisioning - Template extraction always sets page as Published
What is changed:
ProvisioningTemplateCreationInformation.cs - line 34 Added a propery that will control if extracted pages will be drafts or published. Defaults to state Published, to preserve original behavior.
ClientSidePageContentsHelper.cs - line 108, use value from template provisioning information object instead of setting to true.
Tests:
Not run in full, as many provisioning tests require installation of O365 Starter Intranet which is outdated/archived
Third public PR ever, please help me improve. :)
BR
Magnus