ch4/ofi: add mr cache for FI_HMEM_MR#7864
Merged
Merged
Conversation
Collaborator
Author
|
test:mpich/ch4/ofi |
Collaborator
Author
|
test:mpich/ch4/ofi ✔️ |
Expose buffer id so MPICH layer can use buffer id to manage caches.
Add function to retrieve buffer id.
The provider (e.g. EFA) may not cache internally with mr registration.
Without caching, the overhead of mr registration will hurt performance.
Add MPIDI_OFI_mr_cache facility to cache mrs in MPICH. Use a simple
array-based cache for:
1. simplicity
2. cache size limit and LRU eviction
3. stale cache entry detection (optional)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The provider (e.g. EFA) may not cache internally with mr registration.
Without caching, the overhead of mr registration will hurt performance.
Add MPIDI_OFI_mr_cache facility to cache mrs in MPICH. Use a simple
array-based cache for:
1. simplicity
2. cache size limit and LRU eviction
3. stale cache entry detection (optional)
[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.