docs: record the I12 refuse address as 127.0.0.1:1 - #128
Merged
Conversation
PR #124's first commit still describes 127.0.0.2:1 and a mutation-kill that is not in the tree. The code uses 127.0.0.1:1; the load-bearing assertion is port() < 1024. Comments and DESIGN.md now state that mechanism. The red predecessor on main is recorded as known history (#127); the commit graph is not rewritten. Closes #127
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #124 is already on
main. This addresses #127, the leftover from thatPR: comments and DESIGN.md still (or in the commit message, still) told
the
127.0.0.2:1/ENETUNREACHstory, and cited a mutation-kill(
assert_ne!(ip, 127.0.0.1)) that is not in the tree.The code uses
127.0.0.1:1. The load-bearing assertion isassert!(addr.port() < 1024)— a bind-then-drop of an ephemeral portfails the helper. Both
refused_base_urlcopies and the Testing listnow say that. The red predecessor (
a0f535ffails rust-macos) isrecorded as known history;
mainis not rewritten.I12 is unchanged: no production code, no
.without_url()change.Adversarial review (pre-PR, two lenses)
127.0.0.1:1plus
port() < 1024; the only127.0.0.2mention is history ofa0f535f. Follow-up nit:bind(:0)spelled asbind(127.0.0.1:0).both helpers still carry
port() < 1024; copies did not drift.Verification: all five AGENTS.md commands green.
Closes #127