Repository navigation
Add optional frozen complete-path bias functions - #1472
Open
Zhang-pchao wants to merge 9 commits into
Open
Zhang-pchao wants to merge 9 commits into
Zhang-pchao wants to merge 9 commits into
Conversation
…plumed#1473) (cherry picked from commit a7654be)
(cherry picked from commit 4fe6e11)
(cherry picked from commit 7185d0c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an optional
pathbiasmodule with PATH_LOGMEANEXP, PROBABILITY_MIX and CONDITIONAL_PATH. These stateless actions combine fixed complete-path potentials with explicit normalization and full derivatives. They do not train a model or define a PIMD integrator.Dependencies and license
Stacked on the shared-path OPES feature #1471 and its #1463/#1467 prerequisites. The final module commit contains the new source, module metadata, manual examples and three native regression suites. The module is distributed under LGPL version 3 or later; the source headers and module documentation agree.
Contracts
Keep global partition-function normalization distinct from coordinate-dependent conditional normalization. Preserve all derivatives of fixed normalization functions. Replica-root aggregation and force ownership are explicit. Every bead of a complete path shares a statistical weight; beads are not independent samples. No claim of improved sampling, marginal preservation with an approximate normalizer, or scientific convergence is made.
Validation
Independent MPI/current-master build with all modules passed. Native regressions cover stable log aggregation, analytic/finite-difference derivatives, domain rejection, replica layouts and frozen OPES integration. All OPES regressions also passed. No private models, trajectories or host paths are included.
Documentation
The native current-master
new-manualgenerator and MkDocs build completed. All changed action examples have empty stderr and are absent from the broken-example list. The full manual reports 36 failing example pages outside these actions and missing optional-module/link warnings; the full manual is not claimed to be warning-free. Inherited generic keywords are not all covered by examples.Python/OpenMP CI follow-up
Includes the separately reviewable regression-process lifetime fix #1470, which retains the dynamically loaded kernel during Python shutdown. It preserves two-thread execution and the original numerical reference. This addresses the rt-symfunc shutdown failure observed on the debug runner.
Regression follow-up
Included the accepted
rt-proteinshutdown fix #1473, thert-gridfollow-up #1477, and the timestep-test initialization fix accepted in #1464. The Python configs pass three direct two-thread runs per case with byte-identical reference output; the existing build reports Python unavailable to the native runner. The timestep regression passes through the native runner with poisoned automatic-variable initialization against both v2.10 and master kernels. No reference values, tolerances or thread counts were changed. The Autoconf download failure has a separate upstream CI proposal in #1474.Terminology and companion integration
The module documentation now distinguishes coordinate averaging, CV averaging, bias-energy averaging and probability-ratio averaging.
COUPLINGis distinct from coordinate contraction. The complete-path adapter is proposed in lammps/lammps#5232; lammps/lammps#5233 is an optional coordinate-contraction extension, not a dependency of these stateless functions. Zhang-pchao/molsimflow#1 provides a separate numerical oracle and complete-path analysis.