Repository navigation
Drop support for JDK 17 - #566
Conversation
📝 WalkthroughWalkthroughThe build now requires Gradle to run on Java 21 or later. Java compilation targets release 21. The CI matrix tests Java 21, 25, and 26 instead of Java 17, and the documented test command uses Java 21. The changelog adds a Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@build.gradle.kts`:
- Line 102: Update the commented Gradle test command near the testJavaVersion
example to explicitly use a Java 21-or-later JAVA_HOME for the JVM running
Gradle, or document that prerequisite immediately alongside the command. Keep
-PtestJavaVersion=21 for the test launcher and make the example accurately
represent the settings.gradle.kts requirement.
In `@CHANGELOG.md`:
- Around line 3-6: Replace the placeholder date in the version 9.9.9 changelog
heading with the actual publication date before release, preserving the existing
changelog format.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 956e864c-3c18-4597-8df6-60ec99a1b793
📒 Files selected for processing (4)
.github/workflows/gradle.ymlCHANGELOG.mdbuild.gradle.ktssettings.gradle.kts
| // `-PtestJavaVersion`. | ||
| // Override with, for example: | ||
| // ./gradlew test -PtestJavaVersion=17 | ||
| // ./gradlew test -PtestJavaVersion=21 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
rg -n -C 3 'testJavaVersion|JAVA_HOME|org\.gradle\.java\.home|JavaVersion\.current' \
build.gradle.kts \
settings.gradle.kts \
.github/workflowsRepository: plume-lib/bcel-util
Length of output: 3715
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== relevant files =="
fd -a 'build\.gradle\.kts|settings\.gradle\.kts|gradle\.yml' .
echo
echo "== build.gradle.kts around tests =="
while IFS= read -r f; do
[[ "$f" =~ ^\. ]] && continue
wc -l "$f"
sed -n '90,125p' "$f" | cat -n
done < <(fd 'build\.gradle\.kts' .)
echo
echo "== settings.gradle.kts =="
while IFS= read -r f; do
sed -n '1,15p' "$f" | cat -n
done < <(fd 'settings\.gradle\.kts' .)
echo
echo "== workflow setup-java and run sections =="
while IFS= read -r f; do
wc -l "$f"
sed -n '35,70p' "$f" | cat -n
done < <(fd 'gradle\.yml' .github/workflows)
echo
echo "== documentation/version references =="
rg -n -C 2 'Java 17|Java 21|JAVA_HOME|jdk-21|release-21|release|JavaVersion\.current|setup-java' README* build.gradle.kts settings.gradle.kts .github/workflows || trueRepository: plume-lib/bcel-util
Length of output: 343
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== relevant files =="
git ls-files | grep -E '(^|/)(build|settings)\.gradle\.kts$|^\.github/workflows/gradle\.yml$' || true
echo
echo "== build.gradle.kts =="
wc -l build.gradle.kts
sed -n '90,125p' build.gradle.kts | cat -n
echo
echo "== settings.gradle.kts =="
sed -n '1,15p' settings.gradle.kts | cat -n
echo
echo "== gradle workflow if present =="
if [ -f .github/workflows/gradle.yml ]; then
wc -l .github/workflows/gradle.yml
sed -n '35,70p' .github/workflows/gradle.yml | cat -n
fi
echo
echo "== README/version references =="
git ls-files README* | while IFS= read -r f; do
rg -n -C 2 'Java 17|Java 21|JAVA_HOME|Java .*(build|test)|setup-java|jdk-21' "$f" || true
doneRepository: plume-lib/bcel-util
Length of output: 4425
Document the Java 21 prerequisite before running Gradle.
-PtestJavaVersion=21 only changes the test launcher. The Gradle check in settings.gradle.kts still requires the JVM that runs Gradle to be Java 21 or later, so this command does not work under Java 17. Use a Java 21 JAVA_HOME in the command, or add the prerequisite explicitly.
Proposed documentation change
-// ./gradlew test -PtestJavaVersion=21
+// JAVA_HOME=/path/to/jdk-21 ./gradlew test -PtestJavaVersion=21📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // ./gradlew test -PtestJavaVersion=21 | |
| // JAVA_HOME=/path/to/jdk-21 ./gradlew test -PtestJavaVersion=21 |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@build.gradle.kts` at line 102, Update the commented Gradle test command near
the testJavaVersion example to explicitly use a Java 21-or-later JAVA_HOME for
the JVM running Gradle, or document that prerequisite immediately alongside the
command. Keep -PtestJavaVersion=21 for the test launcher and make the example
accurately represent the settings.gradle.kts requirement.
| ## 9.9.9 (2026-08-??) | ||
|
|
||
| - Requires Java 21 to run. | ||
|
|
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Replace the placeholder release date before release.
2026-08-?? is not a usable changelog date. Set the actual release date when version 9.9.9 is published.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CHANGELOG.md` around lines 3 - 6, Replace the placeholder date in the version
9.9.9 changelog heading with the actual publication date before release,
preserving the existing changelog format.
No description provided.