Fix - Avoid SQL warning when no user session is active during plugin init#1179
Open
Fix - Avoid SQL warning when no user session is active during plugin init#1179
Conversation
Rom1-B
requested changes
Apr 13, 2026
| $available_blocks = []; | ||
|
|
||
| $entity_restrict = isCommandLine() ? [] : getEntitiesRestrictCriteria(PluginFieldsContainer::getTable(), '', '', true); | ||
| $entity_restrict = (isCommandLine() || !Session::getLoginUserID()) ? [] : getEntitiesRestrictCriteria(PluginFieldsContainer::getTable(), '', '', true); |
Contributor
There was a problem hiding this comment.
Normally, you're either in CLI mode or logged in as an authenticated user. It seems to be neither, so I don't think this should be allowed, to avoid creating a security issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
When initializing the plugin during boot (before any user session),
getEntitiesRestrictCriteria()was called without an active session, producingentities_id = ''in the SQL query and triggering a mass MySQL warning (1292: Truncated incorrect DECIMAL value).Fix by skipping entity restriction when no user is logged in (
!Session::getLoginUserID()), consistent with the existing check already in place insetup.php.Error :
Close #1172