Rewrite CODEOWNERS for the refactored team structure - #16
Merged
Conversation
The four previous teams were renamed as part of an org-wide refactor, so every line in this file referenced a slug that no longer resolves: codeowners/errors reported Unknown owner on all five. Two defects are fixed alongside the rename. The catch-all pattern was the last line, and GitHub applies the last matching pattern rather than the most specific one, so it overrode every rule above it and made the three team-specific entries dead. It now leads, and the file is ordered broadest to narrowest with that rule stated at the top. Coverage also grows to the surfaces that had no owner but the catch-all: internal/, cmd/, examples/, .claude/, the module and toolchain files, and the release and security workflows. docs/specifications/ regains a dedicated owner separate from docs prose - it is the wire contract, frozen at the first v* tag, not documentation.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
Updates the repository’s CODEOWNERS file to reflect renamed/restructured org teams and to ensure intended ownership routing works correctly given GitHub’s “last match wins” rule.
Changes:
- Reordered CODEOWNERS patterns from broadest to narrowest (catch-all first) and documented the rationale to prevent accidental overrides.
- Updated all owner slugs to the new team structure and added coverage for previously unowned top-level areas and key root files.
- Added narrower overrides for protocol/spec ownership and frontend-specific surfaces under broader
/docs/,/pkg/,/internal/, and/cmd/rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The org's teams were renamed and restructured, which broke every line of this file:
gh api repos/pluggableharness/agent/codeowners/errorsreportedUnknown owneron all five entries.Why the old file was inert even before the rename
The catch-all was last. GitHub applies the last matching pattern, not the most specific one.
* @pluggableharness/core-maintainerssat on the final line, so it overrode the/api/,/docs/, and/pkg/rules above it —plugin-maintainers,sdk-maintainers, anddocumentation-teamwere never requested for anything. The errors endpoint doesn't flag this: it's semantically valid, just not what was intended.No team had repository access. All four teams had zero repo grants, and a code owner must have write access or better. That has been fixed org-side; every team named here now has
writeor above.What changed
maintainers,protocol-maintainers,sdk-maintainers,kernel-maintainers,frontend-maintainers,docs-maintainers,build-infrastructure,release-engineering,security-response,admins.docs/specifications/regains a dedicated owner. It's the wire contract — frozen at the firstv*tag and permanent for every out-of-tree plugin — not documentation, so it shouldn't inherit the docs team.internal/,cmd/,examples/,.claude/,go.mod/go.sum,buf.yaml,.golangci.yml,.goreleaser.yaml, and the release/security workflows.Not addressed here
protect-maincurrently setsrequire_code_owner_review: false, so this file is notification only — it does not gate merges. Flipping that is a repository-settings change, not a code change.Verify after merge: