Repository navigation
fix: Draw selected WebGL text above markers - #8107
Open
minwookshin wants to merge 5 commits into
Open
minwookshin wants to merge 5 commits into
minwookshin wants to merge 5 commits into
Conversation
Author
|
The fork workflow approval expired before any jobs ran (CI run). Could a maintainer help start fresh CI? |
Author
|
Added the baseline from the normal CI artifact; default, base64 and virtual WebGL comparisons pass, along with all 48 scattergl tests. The map interaction failure reproduces on clean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8081.
Draw WebGL text on the focus canvas after selected markers. Reuse text renderers for each canvas and restore trace ordering when selection mode ends. Marker-only plots retain their existing redraw behavior.
Updated
gl2d_point-selectionfrom the normal CI artifact. The default, base64, and virtual WebGL images all pass pixel comparison against this baseline. All 48 scattergl tests, typecheck, lint, syntax, mock validation, and schema drift checks pass on the current branch. The unrelated map interaction test also fails on cleanmain(0316e60d4).Code assistance: OpenAI Codex; changes reviewed by the contributor.