Conversation
Phase 3 of #200. Inline code, keyboard input, highlight, links and mentions are styled by plain CSS in @plone/plate's styles/content.css instead of Tailwind utilities. Mention marks become data attributes. Comment and suggestion marks render as plain text in the public view; the editor keeps showing them. New tests: a visual test for the inline marks, a contract check for inline and editorial marks, and a reset independence test for the inline styles.
This was referenced Oct 3, 2026
* b2-text-blocks: Move the table drag handle fragment to @plone/quanta Releasing @plone/aurora 1.0.0-alpha.16 Release @plone/contents 1.0.0-alpha.3 Release @plone/publicui 1.0.0-alpha.8 Release @plone/cmsui 1.0.0-alpha.11 Release @plone/agave 1.0.0-alpha.8 Release @plone/theming 1.0.0-alpha.8 Release @plone/layout 1.0.0-alpha.13 Release @plone/blocks 1.0.0-alpha.17 Release @plone/plate 1.0.0-alpha.22 Release @plone/react-router 2.0.0-alpha.7 Release @plone/helpers 2.0.0-alpha.9 Release @plone/registry 4.0.0-alpha.4 Release @plone/quanta 1.0.0-alpha.1 Release @plone/components 5.0.0-alpha.5 Release @plone/client 2.0.0-alpha.8 Release @plone/icons 1.0.0-alpha.1 Release @plone/types 3.0.0-alpha.7 Split Quanta and icons out of @plone/components into @plone/quanta and @plone/icons (#212)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 of #200: inline marks and elements are styled by plain CSS instead of Tailwind utilities, with zero visual change. The only intended change is to comments and suggestions in the public view.
Changes
@plone/plate/styles/content.cssnow styles these, in both the public renderer and the editor:.slate-coderounded-md bg-muted px-[0.3em] py-[0.2em] font-mono text-sm whitespace-pre-wrap.slate-kbdrounded border border-border bg-muted px-1.5 py-0.5 font-mono text-sm+ an arbitraryshadow-[…].slate-highlightbg-highlight/30 text-inherit.slate-afont-medium text-primary underline decoration-primary underline-offset-4.slate-mention,[data-bold],[data-italic],[data-underline]inline-block rounded-md bg-muted px-1.5 py-0.5 align-baseline text-sm font-medium, plus mark-dependentfont-bold/italic/underlineValues read the same Tailwind theme variables with Tailwind's defaults as fallback, as in Phase 2. Themeable tokens:
--block-code-background,--block-kbd-background,--block-highlight-color,--block-mention-background.Three classes turned out to do nothing, so the CSS doesn't reproduce them:
bg-highlight/30generates no CSS, because no theme defines--color-highlight. Highlights render with the browser's defaultmarkyellow. The rule keeps that:background-color: var(--block-highlight-color, Mark).shadow-[rgba(…)…]is parsed by Tailwind as a shadow color. It only sets--tw-shadow-color, never abox-shadow, so keys have no shadow.dark:shadow-[…]variant is dropped, as decided in Remove Tailwind from block content in @plone/plate and @plone/blocks #200; dark mode for content comes from theme tokens.Components
cursor-pointerand selection ring.mentionMarkAttributes()helper used by both versions.<ins>/<del>. The editor still shows them (comment-node.tsx,suggestion-node.tsxare unchanged). This is the one intended change, and no screenshot covers it.Tests
plate/acceptance/visual/inline-marks.test.ts: kbd, highlight, mentions (plain and bold), inline code and a link, in the public view and the editor. The native-blocks fixture didn't cover kbd, highlight or mentions, so these conversions couldn't be checked otherwise. The local reference was generated from the Phase 2 build before converting. The content lives in a new shared fixture,fixtures/inline-marks.ts, so the existing native-blocks screenshots don't change.<del>/<ins>, and a transparent background on commented text.PENDINGloses thecodeandaentries.plate/acceptance/tests/inline-marks-content-css.test.ts: the computed styles of all inline elements match under Agave's preflight, with no reset, and under@plone/theming's simple reset. Without a reset, browsers stylecode,kbdandmarkthemselves. The highlight'scolor: inheritis checked as "equals its paragraph's color".Baselines: the 2 new screenshots need baselines; update with
grepset toInline marks.Validation
CI=1 pnpm visual-test --retries=0: 24/24 pixel-identical, the 22 existing plus the 2 new inline-marks screenshots against their pre-conversion reference.pnpm acceptance-test: 173 passed.pnpm --filter @plone/plate test --run: 75 passed.check:ts,eslintandstylelint: clean.Part of #200.