Conversation
Phase 1b of #200. h1 (category text) and hr (category separator) were the Plate-native blocks without anatomy classnames. In the public view, the separator now gets the existing separator category spacing.
… into b1b-anatomy-gaps * origin/b1a-content-contract-foundation: Measure the image block width once again in the style fields test Fix the server not loading translations, which broke hydration (#207)
This was referenced Oct 3, 2026
* b1a-content-contract-foundation: Move the table drag handle fragment to @plone/quanta Releasing @plone/aurora 1.0.0-alpha.16 Release @plone/contents 1.0.0-alpha.3 Release @plone/publicui 1.0.0-alpha.8 Release @plone/cmsui 1.0.0-alpha.11 Release @plone/agave 1.0.0-alpha.8 Release @plone/theming 1.0.0-alpha.8 Release @plone/layout 1.0.0-alpha.13 Release @plone/blocks 1.0.0-alpha.17 Release @plone/plate 1.0.0-alpha.22 Release @plone/react-router 2.0.0-alpha.7 Release @plone/helpers 2.0.0-alpha.9 Release @plone/registry 4.0.0-alpha.4 Release @plone/quanta 1.0.0-alpha.1 Release @plone/components 5.0.0-alpha.5 Release @plone/client 2.0.0-alpha.8 Release @plone/icons 1.0.0-alpha.1 Release @plone/types 3.0.0-alpha.7 Split Quanta and icons out of @plone/components into @plone/quanta and @plone/icons (#212)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1b of #200: the last Plate-native blocks without block anatomy classnames,
h1andhr, get them.Changes
config.blocks.plateBlocksConfig(packages/blocks/index.ts) gets two entries:h1: categorytext, with the same narrow block width as the other headings. Thetitleblock usually takes the place of anh1.hr: categoryseparator.Both now render
block block-<type> category-<category>and thedata-block-*attributes, like every other native block.Visual result: one accepted diff, public view only
In the public view, the separator now gets the category spacing that
@plone/layout'scontent-area.cssalready defines for.category-separator: no bottom spacing on the separator, nor on the block before it. "After the separator" moves up 12px in the native blocks view, desktop and mobile. Those are the only 2 changed screenshots; the other 20 are pixel-identical. The editor is unchanged, becausecontent-area.cssisn't loaded there yet.Baselines: after merging, update with
grepset toNative blocks in the public view.Reordered plan
Moving the shared spacing rules from
content-area.cssinto the shared content styles was planned for Phase 1. It's now a later phase, after the node conversions, and #200 is updated accordingly.I tried it here first. The editor changes were the intended unification, but the public view changed too, from the blockquote down. Nodes like blockquote (
my-1), table of contents (mb-1 p-0) and columns (mb-2) still put Tailwind utilities on their inner containers. Todaycontent-area.cssbeats them from thecustomlayer. Inplone-contentit would sit belowutilitiesand lose. Once those nodes are converted, the move only brings the intended editor changes. The work is kept on a local branch for that phase.Validation
CI=1 pnpm visual-test --retries=0: 20 identical, and 2 accepted diffs (above).pnpm acceptance-test: 170 passed, including the content class-contract test and Fix the server not loading translations, which broke hydration #207's hydration test. One unrelated flake inpaste.test.ts› "Pasting from Word…" on the first run; it then passed 20/20 with--repeat-each=5./layers.cssis still the first stylesheet in the served HTML on every route (public, login, editor, contents), and the order after hydration is the same.pnpm --filter @plone/blocks test --run: 29 passed.check:ts: clean.Part of #200.