Repository navigation
test: give the repeat and conditional-flow fixtures a visible area - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6 made an element with no area count as not visible. Three IntegrationTest fixtures had zero-area elements that the test needs to see, so
./gradlew testhas been broken onmainsince #6:Bounds(0, 100, 100, 100)(the fake driver's bounds are left, top, right, bottom, so zero height).assertVisible: "Value 3"always failed.runFlowwas skipped andassertVisible: Clickedfailed.repeat while notVisible: "Value 3"has notimescap, so the loop never ends. This is why the Test job runs until it times out (the unit test job has notimeout-minutes, so that's GitHub's 6-hour default) instead of failing.Each element now gets a real 100 × 100 box. Cases 073, 074 and 132 also have zero-area elements but don't depend on them being visible, so they're unchanged.
#11 carries the same change folded into its #6 commit, so whichever lands second drops it cleanly.
Testing
main: 049 and 082 fail, and 075 hangs until killed.maestro-testsuite (217 tests) passes in 52 s.