Skip to content

test: give the repeat and conditional-flow fixtures a visible area - #14

Merged
aubrey-wodonga merged 1 commit into
mainfrom
aubrey/zero-area-test-fixtures
Oct 30, 2026
Merged

aubrey-wodonga merged 1 commit into
mainfrom
aubrey/zero-area-test-fixtures

Conversation

@aubrey-wodonga

Copy link
Copy Markdown
Member

#6 made an element with no area count as not visible. Three IntegrationTest fixtures had zero-area elements that the test needs to see, so ./gradlew test has been broken on main since #6:

  • Case 082 (repeat while true): the counter view was Bounds(0, 100, 100, 100) (the fake driver's bounds are left, top, right, bottom, so zero height). assertVisible: "Value 3" always failed.
  • Case 049 (run flow conditionally): the "Not Clicked" indicator had zero width, so the conditional runFlow was skipped and assertVisible: Clicked failed.
  • Case 075 (repeat while): the same zero-height counter view. repeat while notVisible: "Value 3" has no times cap, so the loop never ends. This is why the Test job runs until it times out (the unit test job has no timeout-minutes, so that's GitHub's 6-hour default) instead of failing.

Each element now gets a real 100 × 100 box. Cases 073, 074 and 132 also have zero-area elements but don't depend on them being visible, so they're unchanged.

#11 carries the same change folded into its #6 commit, so whichever lands second drops it cleanly.

Testing

  • On main: 049 and 082 fail, and 075 hangs until killed.
  • With this change: 049, 075 and 082 pass, and the whole maestro-test suite (217 tests) passes in 52 s.

@aubrey-wodonga aubrey-wodonga self-assigned this Oct 30, 2026
@aubrey-wodonga
aubrey-wodonga merged commit d82b7ce into main Oct 30, 2026
17 checks passed
@aubrey-wodonga
aubrey-wodonga deleted the aubrey/zero-area-test-fixtures branch October 30, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant