Repository navigation
fix(deps): resolve transitive bun audit vulnerabilities - #40
Merged
Merged
Conversation
The website lockfile is now written by bun 1.4.3, which bun 1.3.14 cannot read (UnknownLockfileVersion). mise resolves the website's bun from this field when idiomatic version files are enabled, so keep it in sync with the root mise.toml.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
amondnet
marked this pull request as ready for review
October 17, 2026 14:13
|
[High impact] The PR appears safe to merge; no actionable issues were found. SummaryUpdates transitive dependencies in the root project and docs website.
Reviews (1) · Last reviewed commit: "style(website): sort override keys for j..." · Reviewed by Greptile |
There was a problem hiding this comment.
No issues found across 4 files
Architecture diagram
sequenceDiagram
participant Dev as Developer
participant CLI as Bun CLI (1.4.3)
participant Lock as Lockfile (bun.lock)
participant Reg as npm Registry
participant Root as Root package.json
participant Web as website/package.json
participant Build as Build Pipeline
Note over Dev,Build: Dependency resolution and audit flow
Dev->>CLI: bun install --frozen-lockfile
CLI->>Root: Read package.json (root)
CLI->>Web: Read package.json (website)
Root->>Root: Apply overrides (decode-uri-component, katex)
Web->>Web: Apply overrides (postcss-selector-parser, miniflare.undici)
CLI->>Reg: Resolve dependency tree
Reg-->>CLI: Package metadata + versions
CLI->>Lock: Verify lockfile version (bun 1.4.3 compatible)
alt Lockfile version mismatch (bun 1.3.14)
Lock-->>CLI: UnknownLockfileVersion error
CLI-->>Dev: Fail with error
else Lockfile readable (bun 1.4.3)
Lock->>Lock: Resolve with overrides applied
Lock-->>CLI: Frozen dependency tree
CLI-->>Dev: Install complete
end
Dev->>CLI: bun audit
CLI->>Lock: Scan resolved dependencies
Lock-->>CLI: Vulnerability report
alt Vulnerabilities found
CLI-->>Dev: Report findings (0 expected)
else No vulnerabilities
CLI-->>Dev: "No vulnerabilities found"
end
Note over Dev,Build: Build and verification flows
Dev->>CLI: bun run build
CLI->>Build: Execute build script
Build->>Root: Use root dev tooling (postcss, nanoid, katex)
Build->>Web: Use website deps (astro, wrangler, miniflare)
Build->>Build: Process with postcss-selector-parser (patched 7.x)
Build->>Build: Use undici 7.x (scoped to miniflare)
alt unifont also requires undici
Build->>Build: Keep undici 8.x for unifont
end
Build-->>Dev: Build complete (14/14 root, 22 pages website)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
#34 closed the 13 open Dependabot alerts on
main(1 critical, 5 high, all astro/sharp inwebsite/package.json).bun auditstill reported vulnerabilities in transitive dependencies that Dependabot had not alerted on. This PR clears them in both the root project andwebsite/, and alignswebsite'spackageManagerwith the bun version that now writes its lockfile.What changed
bun audit13 vulnerabilities (9 high, 3 moderate, 1 low) → 0.bun audit fix): brace-expansion 5.0.6 → 5.0.12, nanoid 3.3.12 → 3.3.18, postcss 8.5.15 → 8.5.23, source-map-js 1.2.1 → 1.2.2.decode-uri-component^0.5.0(pulled by query-string via autumn-js) andkatex^0.18.2(only via micromark-extension-math in the ESLint markdown tooling).website:bun audit19 (6 high, 10 moderate, 3 low) → 0.postcss-selector-parser^7.1.6(postcss-nested declares^6.1.1and no patched 6.x exists), andminiflare: { undici: "^7.29.1" }(miniflare pins undici 7.28.0 exactly; scoped so unifont keeps undici 8.x).website/package.json:packageManagerbun@1.3.14 → bun@1.4.3. The lockfile is now written by bun 1.4.3, which 1.3.14 cannot read (UnknownLockfileVersionon--frozen-lockfile), and mise resolves bun from this field. This matches the root (build: upgrade bun to 1.4.3 and type-check with bun check #35).Scope
Dependency and lockfile changes only. No source changes.
Blast radius
Every affected root package is dev tooling, and root
overridesdo not reach consumers of the published packages. Thewebsitechanges affect only the docs build.Related issue
None.
Verification
bun install --frozen-lockfile,bun run lint,bun run type-check(27/27),bun run test:coverage(290 pass, 0 fail; autumn emulator tests 15/15),bun run build(14/14).website, mirroringdocs.yml:bun install --frozen-lockfile,bun scripts/sync-services.ts(services/unchanged),bun run build(22 pages).bun auditin both projects: "No vulnerabilities found".Checklist
bun run test)bun run lint)BREAKING CHANGE:note is includedSummary by cubic
Resolves transitive
bun auditvulnerabilities in the root project and the docs website without changing runtime behavior, bringing both projects to zero findings.Root: in-range updates to
brace-expansion,nanoid,postcss, andsource-map-js, plus overrides fordecode-uri-componentandkatex, both pulled only by dev tooling. Website: updates tojs-yamlandsource-map-js, plus an override forpostcss-selector-parser(no patched 6.x exists) and anundicioverride scoped tominiflaresounifontstays on undici 8.x.Notes
websitepackageManagerbumps to bun@1.4.3 so the lockfile, now written by 1.4.3, is readable under--frozen-lockfile.overridesdo not reach published consumers.Written for commit c632488. Summary will update on new commits.