[amondnet]

Summary

bunx pyright-langserver asks the registry for an npm package named pyright-langserver, which does not exist (404). pyright-langserver is a bin of the pyright package, so the fallback never worked, and the unclaimed name was a squatting risk (same as #133 for biome). The fallback now runs bunx -p pyright@1.1.414 pyright-langserver --stdio, pinned through an exported PYRIGHT_VERSION.

• Checks for bunx with Bun.which('bunx', { PATH }) before spawning. If it is missing, logs pyright not found. Install with: npm install pyright and returns undefined, so LSPManager marks the server broken instead of waiting out the initialize timeout.
• Removes the dead try/catch: spawn reports ENOENT as an async 'error' event, so it never fired. Spawns the resolved absolute bunx path, as biome.ts (fix(lsp): run a pinned @biomejs/biome in the biome bunx fallback #134) and typescript.ts (fix(lsp): check for bunx before the typescript bunx fallback #136) do.
• Bun.which('pyright-langserver') now passes the current PATH, like the other servers.

Out of scope (per the issue notes): a broken mise shim on PATH (pyright-langserver has no --version to probe) and a project-local node_modules/.bin lookup.

Related issue

Closes #137

Verification

New PyrightServer fallback describe in packages/lsp/test/unit/server.test.ts: the pinned bunx command, preferring pyright-langserver on PATH, and undefined plus the install hint when bunx is missing.

• The pinned-command and missing-bunx tests fail against the old pyright.ts.
• Full lsp unit suite: 176 pass, 0 fail.
• tsc --noEmit for packages/lsp passes; eslint is clean.
• Manual: bunx -p pyright@1.1.414 pyright-langserver --stdio starts "Pyright language server 1.1.414".

Checklist

• PR title follows Conventional Commits
• Tests added or updated, and the suite passes (bun run test)
• Lint/format pass (bun run lint)
• Documentation updated if behavior changed (no documented behavior changed)
• No breaking change, or a BREAKING CHANGE: note is included

---

Summary by cubic

Fixes the pyright bunx fallback, which never worked because bunx pyright-langserver requested a nonexistent npm package (pyright-langserver is a bin of the pyright package) and the unclaimed name was a squatting risk.

• The fallback now runs bunx -p pyright@1.1.414 pyright-langserver --stdio, pinned through the exported PYRIGHT_VERSION.
• Checks for bunx with Bun.which before spawning and removes the dead try/catch, so a missing bunx returns undefined and logs pyright not found. Install with: npm install pyright instead of waiting out the initialize timeout.
• Passes the current PATH to Bun.which, matching the biome and typescript servers.
• Adds PyrightServer fallback tests covering the pinned command, preferring pyright-langserver on PATH, and the missing-bunx hint.

Closes #137.

^{Written for commit 205a0a8. Summary will update on new commits.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
packages/lsp/src/server/pyright.ts	78.57%	3 Missing ⚠️

📢 Thoughts on this report? Let us know!

[gemini-code-assist]

Code Review

This pull request updates the Pyright LSP server implementation to fallback to spawning bunx with a pinned Pyright version (1.1.414) when pyright-langserver is not found on the system PATH. It also adds corresponding unit tests to verify this fallback behavior, path preferences, and error handling when bunx is missing. Feedback on these changes suggests avoiding redundant Bun.which checks before spawning processes, recommending instead to wrap process spawning in a try/catch block to handle missing executables.

[cubic-dev-ai]

cubic analysis

No issues found across 2 files

Linked issue analysis

Linked issue: pleaseai/code-intelligence#137: fix(lsp): pyright bunx fallback requests a nonexistent npm package, is unpinned, and never detects a missing bunx

Status	Acceptance criteria	Notes
✅	Run the pyright binary from a pinned package	The fallback runs pyright-langserver from pyright@1.1.414 using the exported version constant.
✅	Return undefined with an install hint when bunx is missing	The server checks for bunx before spawning, logs the install hint, and returns undefined when absent.
✅	Use the current PATH for both executable lookups	Both pyright-langserver and bunx lookups pass the current process.env.PATH to Bun.which.
✅	Prefer an installed pyright-langserver over the fallback	The server spawns pyright-langserver directly when found, and the test verifies bunx is bypassed.

Architecture diagram

sequenceDiagram
    participant Client as LSP Client
    participant LM as LSPManager
    participant PS as PyrightServer (spawn)
    participant PN as process.env.PATH
    participant BX as bunx CLI
    participant npm as npm Registry

    Note over Client,PS: Pyright server startup flow

    LM->>PS: spawn(root)
    
    alt pyright-langserver found on PATH
        PS->>PN: Read current PATH
        PS->>PS: Bun.which('pyright-langserver', { PATH })
        alt Found
            PS->>PS: spawn(pyright, ['--stdio'])
            PS-->>LM: process handle
        else Not found
            Note over PS: Fallback needed
            PS->>PS: Bun.which('bunx', { PATH })
            alt bunx not found
                PS->>PS: Log install hint
                PS-->>LM: undefined (broken server)
            else bunx found
                PS->>BX: spawn(bunx, ['-p', 'pyright@1.1.414', ...])
                BX->>npm: Resolve pyright@1.1.414
                npm-->>BX: pyright package
                BX->>BX: Run pyright-langserver --stdio
                BX-->>PS: LSP process
                PS-->>LM: process handle
            end
        end
    end

Loading

_{Turn on auto-fix | Re-trigger cubic}

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Fixes the Pyright fallback to run pyright-langserver from the pinned pyright package.

• Pyright starts from a pinned package when its command is not on PATH.

No actionable issues found.

_{Reviews (1) · Last reviewed commit: "fix(lsp): run a pinned pyright in the py..." · Reviewed by Greptile}