[amondnet]

Summary

DartServer.spawn (packages/lsp/src/server/dart.ts) used Bun.which('dart') and spawned whatever resolved. A mise shim with no Dart version configured resolves on PATH but exits 1 (mise ERROR No version is set for shim: dart), so the server died instead of using the auto-downloaded SDK. Spawn now probes the system dart first and falls back to the download path when it cannot run.

• New exported findSystemDart() runs dart --version (async Bun.spawn, same pattern as oxlint's --help probe) and returns the system path only on exit 0.
• Otherwise it logs a warning with the exit code and the first 200 chars of stderr, and spawn falls through to the existing auto-download path.
• Scope: findSystemDart is not re-exported publicly (server/index.ts imports only DartServer). This is the src/server/dart.ts:120 item that test(lsp): skip dart integration tests when dart cannot run #128 listed as remaining work.

Verification

• Two unit tests in packages/lsp/test/unit/server.test.ts use a fake failing and a fake working dart on PATH. They run in a child bun process because Bun.which reads PATH at process startup.
• Bun 1.4.3: bun run typecheck passes, eslint is clean, and bun test ./test/unit in packages/lsp gives 162 pass / 0 fail.
• End-to-end on a machine with the broken mise shim: LSPManager on test/fixtures/dart-project skipped the shim, started from the cached SDK in \~/.cache/dora/dart-lsp, reported connected, and workspaceSymbol('Calculator') returned 1 result.
• The full bun run test was not run locally because the Vue integration tests still fail locally (VueServer and DartServer integration tests fail locally in packages/lsp #127). CI covers it.

Related issue

Refs #127 (it also covers the Vue integration failures, which remain open)

Checklist

• PR title follows Conventional Commits
• Tests added or updated (unit tests; the full suite bun run test is left to CI)
• Lint/format pass (bun run lint)
• Documentation updated if behavior changed - n/a, no documented behavior changes
• No breaking change

---

Summary by cubic

Fixes the Dart LSP server crashing when the system dart resolves on PATH but cannot actually run, such as a mise shim without an SDK version configured. The server now probes the system dart with dart --version and falls back to the auto-downloaded SDK when it cannot run.

• findSystemDart() looks up dart on the current PATH and returns the resolved path only when dart --version exits 0 in the project root within a 10s timeout.
• On failure it warns with the exit code, signal, or spawn error, then falls back to the auto-downloaded SDK.
• Adds in-process unit tests for failing, unspawnable, and working fake dart scripts on PATH, skipped on Windows.

^{Written for commit a13a4f6. Summary will update on new commits.}

[gemini-code-assist]

Code Review

This pull request introduces a findSystemDart helper function to verify that the system Dart binary is functional by running its version command before using it, preventing issues with unconfigured version-manager shims. It also adds corresponding unit tests. The review feedback correctly identifies a robustness issue where Bun.spawn could throw a synchronous error due to permission issues, which would crash the LSP server startup instead of falling back to the auto-downloaded SDK. Wrapping the spawning logic in a try-catch block is recommended to handle this safely.

[codecov]

Codecov Report

❌ Patch coverage is 72.41379% with 8 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
packages/lsp/src/server/dart.ts	72.41%	8 Missing ⚠️

📢 Thoughts on this report? Let us know!

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new blocking issue was found.

Summary

The PR checks whether system Dart can run before starting its language server. Failed probes fall back to the downloaded SDK.

• Dart startup skips system executables that fail a version check.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Dart server requested] --> B[Find Dart on current PATH]
  B --> C{Executable found?}
  C -->|No| F[Use downloaded SDK]
  C -->|Yes| D[Run version check in project root]
  D --> E{Check succeeds?}
  E -->|No or launch error| F
  E -->|Yes| G[Start system Dart language server]

Loading

_{Reviews (3) · Last reviewed commit: "refactor(lsp): look up system dart on th..." · Reviewed by Greptile}

[amondnet]

/gemini review

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[cubic-dev-ai]

No issues found across 2 files

Architecture diagram

sequenceDiagram
    participant LSP as LSP Manager
    participant DS as DartServer (dart.ts)
    participant FS as findSystemDart()
    participant PATH as System PATH
    participant BUN as Bun Runtime
    participant DL as Auto-Download SDK

    Note over LSP,DL: Dart LSP Server Startup Flow

    LSP->>DS: spawn(root)
    
    DS->>FS: findSystemDart(root)
    
    FS->>PATH: Bun.which('dart')
    alt System dart found on PATH
        PATH-->>FS: systemDart path
        FS->>BUN: Bun.spawn([dart, '--version'], { cwd: root })
        
        alt Probe succeeds (exit 0)
            BUN-->>FS: exit 0
            FS-->>DS: return systemDart path
        else Probe fails (non-zero exit or spawn error)
            BUN-->>FS: exit != 0 / signal / error
            FS->>FS: Log warning with exit code + stderr
            FS-->>DS: return undefined
        end
    else No system dart on PATH
        PATH-->>FS: undefined
        FS-->>DS: return undefined
    end
    
    alt Valid system Dart available
        DS->>BUN: spawn(systemDart, ['language-server', ...])
        BUN-->>LSP: LSP process started
    else Falling back to auto-downloaded SDK
        DS->>DL: Fetch/download cached Dart SDK
        DL-->>DS: SDK path
        DS->>BUN: spawn(downloadedSDK, ['language-server', ...])
        BUN-->>LSP: LSP process started
    end

Loading

_{Turn on auto-fix | Re-trigger cubic}

Dismissed because a newer commit was pushed; Greptile will re-review the current head.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud