Skip to content

build: upgrade bun to 1.4.3 and use bun check for typecheck #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amondnet merged 4 commits into from
Oct 21, 2026
Merged

build: upgrade bun to 1.4.3 and use bun check for typecheck #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
047940b
build(deps): upgrade bun to 1.4.3
amondnet Oct 21, 2026
ab22041
build: use bun check for typecheck scripts
amondnet Oct 21, 2026
cd32ead
ci: pin bun-version to 1.4.3 in workflows
amondnet Oct 21, 2026
b29bf34
chore: apply AI code review suggestions
amondnet Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:

- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: latest
bun-version: 1.4.3

- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
Expand All @@ -50,7 +50,7 @@ jobs:

- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: latest
bun-version: 1.4.3

- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
Expand All @@ -71,7 +71,7 @@ jobs:

- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: latest
bun-version: 1.4.3

- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:

- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: latest
bun-version: 1.4.3

- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
Expand Down
2 changes: 1 addition & 1 deletion ARCHITECTURE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ These are constraints that must be maintained. Violating them will break things.

### Build & Release

- **Package manager**: Bun 1.3.5+
- **Package manager**: Bun 1.4.3+
- **Build orchestration**: Turborepo with `build → typecheck → test` pipeline.
Package builds depend on their upstream packages (`^build`).
- **Release**: release-please for changelog generation and version bumps.
Expand Down
47 changes: 13 additions & 34 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion hooks/scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"author": "Minsu Lee",
"license": "MIT",
"scripts": {
"typecheck": "tsc -p tsconfig.json --noEmit",
"typecheck": "bun check -p tsconfig.json",
"test": "bun test ./test"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

[tools]
node = "24"
bun = "1.3.5"
bun = "1.4.3"

[tasks.dev]
description = "Run development mode (watch)"
Expand Down
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "code-please",
"type": "module",
"version": "0.1.25",
"packageManager": "bun@1.3.5",
"packageManager": "bun@1.4.3",
Comment thread
amondnet marked this conversation as resolved.
Comment thread
amondnet marked this conversation as resolved.
"description": "Auto-format and type-check hooks for AI coding",
"license": "MIT",
"repository": {
Expand All @@ -15,7 +15,7 @@
"hooks/scripts"
],
"engines": {
"bun": ">=1.0.0"
"bun": ">=1.4.3"
Comment thread
amondnet marked this conversation as resolved.
},
"scripts": {
"start": "bun run packages/code/src/cli.ts",
Expand All @@ -42,6 +42,7 @@
"@commitlint/config-conventional": "^21.2.0",
"@pleaseai/eslint-config": "^0.0.4",
"@types/bun": "latest",
"@types/node": "^26.6.5",
"eslint": "^10.6.0",
"husky": "^9.1.7",
"lint-staged": "^16.2.7",
Expand Down
2 changes: 1 addition & 1 deletion packages/binaries/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"src"
],
"scripts": {
"typecheck": "tsc -p tsconfig.json --noEmit",
"typecheck": "bun check -p tsconfig.json",
Comment thread
amondnet marked this conversation as resolved.
"test": "bun test ./test"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/code/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"scripts": {
"dev": "bun --watch run src/cli.ts",
"build": "echo 'Build handled by root build:npm'",
"typecheck": "tsc -p tsconfig.json --noEmit",
"typecheck": "bun check -p tsconfig.json",
"test": "bun test ./test"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/dora/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"scripts": {
"dev": "bun --watch run src/cli.ts",
"build": "echo 'Build handled by root build:npm'",
"typecheck": "tsc -p tsconfig.json --noEmit",
"typecheck": "bun check -p tsconfig.json",
"test": "bun test ./test"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/format/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"src"
],
"scripts": {
"typecheck": "tsc -p tsconfig.json --noEmit",
"typecheck": "bun check -p tsconfig.json",
"test": "bun test ./test"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/logger/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"src"
],
"scripts": {
"typecheck": "tsc -p tsconfig.json --noEmit",
"typecheck": "bun check -p tsconfig.json",
"test": "bun test ./test"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/lsp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"src"
],
"scripts": {
"typecheck": "tsc -p tsconfig.json --noEmit",
"typecheck": "bun check -p tsconfig.json",
"test": "bun test ./test",
"test:unit": "bun test ./test/unit",
"test:integration": "bun test ./test/integration"
Expand Down
Loading