Fix submodule_search_locations with module_dir setting - #324
Merged
Merged
Conversation
chrisnovakovic
approved these changes
Sep 14, 2026
peterebden
force-pushed
the
peter/submodule-search-patch
branch
from
September 14, 2026 16:17
f292e59 to
3128dd0
Compare
peterebden
force-pushed
the
peter/submodule-search-patch
branch
from
September 15, 2026 11:58
3128dd0 to
6842edf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a (rapidly expanding) set of patches internally complaining about this. I figured it was time to fix it - this ensures it is set properly which fixes some usages of
importlib.resources.