Update reported max API version to latest - #363
Open
peterebden wants to merge 6 commits into
Open
peterebden wants to merge 6 commits into
peterebden wants to merge 6 commits into
Conversation
peterebden
commented
Sep 19, 2026
| ExecEnabled: true, | ||
| }, | ||
| LowApiVersion: &semver.SemVer{Major: 2, Minor: 0}, | ||
| HighApiVersion: &semver.SemVer{Major: 2, Minor: 1}, // optimistic |
Member
Author
There was a problem hiding this comment.
our optimism here eventually paid off and it did get tagged, quite some time after this comment.
| @@ -0,0 +1,254 @@ | |||
| # AGENTS.md | |||
Member
Author
There was a problem hiding this comment.
Adding this while I'm here
peterebden
changed the title
toastwaffle
approved these changes
Sep 21, 2026
| rootDigest, err := digest.NewFromMessage(tree.Root) | ||
| require.NoError(t, err) | ||
| assert.Equal(t, rootDigest.ToProto(), outDir.RootDirectoryDigest) | ||
| assert.NotEqual(t, digest.Digest{}, rexclient.PackDigest(tree.Root)) |
Contributor
There was a problem hiding this comment.
Why do we only assert that it is non-zero, but not assert what it actually is?
| sub := &pb.Directory{} | ||
| require.NoError(t, proto.Unmarshal(blob(t, entries, root.Directories[0].Digest), sub)) | ||
| require.Len(t, sub.Files, 1) | ||
| assert.Equal(t, "b.txt", sub.Files[0].Name) |
Contributor
There was a problem hiding this comment.
require.Len(t, sub.Directories, 0)? Or not worth it?
| OutputDirectorySymlinks: []*pb.OutputSymlink{dir}, | ||
| })) | ||
|
|
||
| // output_symlinks is already populated, which takes priority |
Contributor
There was a problem hiding this comment.
This test doesn't actually assert that output_symlinks takes priority; allOutputSymlinks could still read the deprecated fields and pass this test.
| @@ -0,0 +1,254 @@ | |||
| # AGENTS.md | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle newer symlink field for a client that sends that, and populate the new
root_directory_digestfield for a client that wants it.Not much to do otherwise, we already supported most of the features of earlier versions (like compression) before they got (retroactively) tagged. There are other changes, mostly around multiple digest functions and split-and-splice but they're opt-in and we're a SHA-256 only server so we don't have to support any of them.
Update to a more recent Go version while I'm here.
I have not upgraded
remote-apis-sdks. There are various changes in it which are IMO highly questionable (silently ignoring unreadable outputs and aggressively opening 25 parallel connections to the CAS server) and relatively little that looks particularly useful for us.