Skip to content

Consume RPC messages once - #219

Merged
smnandre merged 2 commits into
playwright-php:mainfrom
kbond:codex/consume-rpc-messages-once
Nov 18, 2026
Merged

smnandre merged 2 commits into
playwright-php:mainfrom
kbond:codex/consume-rpc-messages-once

Conversation

@kbond

@kbond kbond commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Consume incoming messages before running callbacks and keep replies only for active synchronous requests. Preserve nested replies without replaying events or retaining completed asynchronous responses.

@codecov

codecov Bot commented Nov 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Transport/JsonRpc/ProcessJsonRpcClient.php 90.90% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@smnandre
smnandre force-pushed the codex/consume-rpc-messages-once branch from 18b93f8 to 76abf8e Compare November 17, 2026 23:37
@smnandre
smnandre merged commit c374912 into playwright-php:main Nov 18, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants