Repository navigation
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the Play-patched hibernate-core jar and its build infrastructure, migrating the framework to a vanilla Hibernate ORM 7.4.14.Final. The Play-specific flush semantics (
JPABase.willBeSaved), previously injected via a source patch of hibernate-core, are now implemented in the framework itself as forked flush event listeners, registered programmatically at bootstrap.Play flush semantics as framework code (instead of patching Hibernate)
play.db.jpa.PlayAbstractFlushingEventListener— fork of Hibernate 7.4AbstractFlushingEventListenerwith two Play changes: skip flush-time cascades forJPABaseentities withwillBeSaved == false, and veto collection recreate/remove/update actions for collections whose owner (or the entity being saved) is not going to be savedPlayFlushEventListener/PlayAutoFlushEventListener— forks ofDefaultFlushEventListener/DefaultAutoFlushEventListener(the latter is required, otherwise auto-flush on queries would use vanilla cascades)PlayHibernateIntegratorregisters them forEventType.FLUSH/EventType.AUTO_FLUSH; wired fromJPAPluginviaJpaSettings.INTEGRATOR_PROVIDER(accepted as an instance, no ServiceLoader needed)Each fork file contains the upstream 7.4.14 source kept as close to original as possible, with every Play change wrapped in
// [play] ... // [/play]markers;framework/patches/hibernate-7.4.14-patch-play-fork.patch+ README record the changes and document the upgrade workflow (copy upstream sources → rename → apply patch)