Give sbt server enough heap for Scala Native tests - #1454
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
sbt validateCodeandbash -n scripts/test-code.sh.Purpose
Give the sbt server a 4 GB maximum heap for the
testFulljob by settingJAVA_OPTS. Preserve any existingJAVA_OPTSvalue and remove the ineffective-JRAM percentage options.Background Context
The sbt 2 runner starts its native thin client by default. That client drops command-line
-Joptions before starting the server, so the previous memory settings left the server at its default 1 GB heap. This caused out-of-memory failures during the Scala Native test job.JAVA_OPTSreaches the server at startup. A previous Java 21 / Scala 3.9testFullrun passed with the 4 GB setting.Verification
JAVA_OPTS=-Xmx4G sbt validateCodepassed.bash -n scripts/test-code.shandgit diff --checkpassed.scripts/test-code.shon pull requests.References
-Joptions to sbt server sbt/sbt#9839