Repository navigation
refactor: move core package into packages/ - #41
Merged
Merged
Conversation
Move @platformatic/sqlite-js-stream from the repo root to packages/sqlite-js-stream so every published package lives under packages/. The repo root becomes a private pnpm workspace container: orchestration scripts move there, the shared tsconfig stays as the base/repo-wide typecheck, and sub-package tests update their imports of the core's shared helpers. Also remove the stray untracked packages/paged-vfs directory (it had no package.json).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
@platformatic/sqlite-js-streamfrom the repo root intopackages/sqlite-js-stream, so every published package lives underpackages/. The repo root becomes a private pnpm workspace container that only keeps the monorepo-level config (workspace, tsconfig base/repo typecheck, eslint, version-bump script, workflows).This follows the layout the sibling packages (
backend-s3,backend-pg,sqlite-js-stream-paged-vfs) already use.Orchestration scripts (build, typecheck, lint, test:all, test:paged-vfs, bench, golden:go) moved to the root package.json; the core package keeps only its own test/build/prepack/bench scripts. Sub-package tests that import the core's shared test helpers now use
../../sqlite-js-stream/test/helpers/.... The version-bump script reads the base version from the core package and bumps onlypackages/*, and the CI/release workflow paths were updated. The stray untrackedpackages/paged-vfsdirectory (which had nopackage.json) was removed.Verified: build, repo-wide typecheck, lint, the core suite (158 pass, 0 fail), and the S3 suite (43 pass, 0 fail) all pass.