Don't call openstackcreds per cluster to get tenant name#2057
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| const projectNameByCred = new Map<string, string>( | ||
| (openstackCredsList || []).map((cred: OpenstackCreds) => [ | ||
| cred.metadata.name, | ||
| cred.spec?.projectName || '' | ||
| ]) | ||
| ) |
There was a problem hiding this comment.
🚩 Behavioral change: individual per-credential error isolation is removed
Beyond the reported bug (Promise.all rejection), there's a subtler behavioral difference even in the success path. The old code fetched each credential individually, so if one credential resource was deleted or corrupted mid-request, only that one cluster's tenant name would be blank. The new code fetches the entire list at once, so a single malformed item in the API response could potentially cause the entire list parse to fail. In practice, since this is a Kubernetes list API that returns well-structured JSON, this is unlikely. However, if the credentials list is paginated or truncated by the API server (e.g., due to continue tokens on very large lists), some credentials might be missing from the lookup map, silently resulting in empty tenant names. The getOpenstackCredentialsList function at openstackCreds.ts:6-12 does not handle pagination (continue token in GetOpenstackCredsListMetadata), so at scale this could lead to incomplete data.
Was this helpful? React with 👍 or 👎 to provide feedback.
spai-p9
force-pushed
the
private/main/ui-tenant-fix
branch
from
1d8e0e5 to
0e00571
Compare
✅ Security Vulnerability SummaryNo change in security posture 📊 Overall Changes
🔍 Detailed Breakdown📦 Gosec (Static Analysis)
📦 Trivy (Dependency Scan)
📋 Baseline Methods
Only HIGH and CRITICAL severity vulnerabilities are tracked |
✅ Security Vulnerability SummaryNo change in security posture 📊 Overall Changes
🔍 Detailed Breakdown📦 Gosec (Static Analysis)
📦 Trivy (Dependency Scan)
📋 Baseline Methods
Only HIGH and CRITICAL severity vulnerabilities are tracked |
✅ Security Vulnerability SummaryNo change in security posture 📊 Overall Changes
🔍 Detailed Breakdown📦 Gosec (Static Analysis)
📦 Trivy (Dependency Scan)
📋 Baseline Methods
Only HIGH and CRITICAL severity vulnerabilities are tracked |
1 participant
What this PR does / why we need it
This PR adds the change instead of calling every openstackcreds to get tenant. get list of openstackcreds before hand and get tenant name from in memory objectl.
Which issue(s) this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged)fixes #2053.
Special notes for your reviewer
Testing done
please add testing details (logs, screenshots, etc.)