Skip to content

Windows: Full-mode manifest still gates open/open-link/last to macos+linux after #31 revert #43

Description

@kursku

Context

On Windows the manifest (bfe0de8, and current main) gates the Full-review entrypoints — the [[build]], the doc pane, and the open / open-link / last actions plus the markdown link_handler — to ["macos","linux"]. So Windows users get only capture / copy-* / manage; the whole plannotator-tui review flow is unreachable, even though scripts/fetch-plannotator-tui.ps1 exists and the tui ships an x86_64-pc-windows-msvc.exe asset.

I ran the ps1 locally: it fetches + sha256-verifies + stages bin/plannotator-tui.exe (0.7.0) cleanly, and plannotator-tui.exe --version runs. Flipping the three actions to include windows makes them work as-is, since Herdr's relative-program resolver applies to actions (they use ./bin/plannotator-tui.exe).

The real blocker (why #30 was reverted in #31)

The doc pane command can't use ./bin/… — the resolver doesn't apply to panes; they spawn with the review folder as --cwd. The Unix manifest sidesteps this with a wrapper resolving via $HERDR_PLUGIN_ROOT:

["sh","-c","exec bash \"$HERDR_PLUGIN_ROOT/scripts/plannotator-tui.sh\" herdr pane"]

That wrapper needs sh+bash, which native Windows (no Git Bash) lacks. That's the piece still missing for a clean Windows re-enable.

Question

Would a pwsh-based pane wrapper resolving the binary via $HERDR_PLUGIN_ROOT (mirroring the pattern herdr-file-viewer / herdr-sidebar already use for their -windows action variants) be the accepted path to re-land Windows Full-mode? Happy to open a PR along those lines if so.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions