fix(controller): warm the WebView browser in beforeAll — the transport-seam flake - #346
Merged
Merged
Conversation
…t-seam flake The `constructs and accepts the injected transport` spec timed out at 20s on a cold CI runner: the first Bun.WebView in a process pays cold headless-Chrome startup, and the test-level 20s budget was too small to absorb it. Warm the chrome backend with one throwaway view in beforeAll (60s hook budget) so the specs run against a warm browser. Applied to both WebView harnesses (controller.spec.ts and transport-seam.spec.ts); controller.spec's harness notes document the warm-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
controller: injectable transport seam > constructs and accepts the injected transportspec flaked onmain(run 35867400677, first attempt): the firstBun.WebViewin a test process pays cold headless-Chrome startup, and on a cold CI runner that exceeded the test's 20s budget.Summary
beforeAll(60s hook budget) with a throwaway view so every spec runs against a warm browser. Applied to both WebView harnesses (controller.spec.ts,transport-seam.spec.ts); the controller harness notes document the warm-up.Changed Files
src/controller/tests/controller.spec.ts— beforeAll warm-up + harness-notes bullet.src/controller/tests/transport-seam.spec.ts— beforeAll warm-up.Known Failures / Drift
bun run checkclean; full suite 605 pass / 0 fail (bun 1.4.2). First WebView test dropped from ~795ms to ~138ms locally.Review Notes / Residual Risks
{ retry: N }) was considered and rejected: it masks the cold start and taxes every cold run with a full-timeout burn. The warm-up pays the cost once.