Magration to node-gyp, fixed compatibility issues with node 0.10.x - #15
Open
twoRoger wants to merge 3 commits into
Open
Magration to node-gyp, fixed compatibility issues with node 0.10.x#15twoRoger wants to merge 3 commits into
twoRoger wants to merge 3 commits into
Conversation
Owner
|
Thanks! This is really interesting - two people submitted the same patch for migrating to node 0.10 at (almost) the same time! Now which patch do I accept? The other patch is: #16 Let's review both patches and accept the best one! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration from eio_custom to uv_queue_work
node-gyp