Fix insertbin expression in ROM write statements#1
Open
PhoenixBound wants to merge 1 commit into
Open
Conversation
ROM write statements didn't preserve the "file" name, which is what InsertBinExpr uses to determine which paths to search for binary data. When given a completely blank path for the current file, the binary data would only be searched for in the parent of the working directory! Pass along the file name when a new EvalContext is created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can now put
insertbinexpressions inside of ROM[] and ROMTBL[] statements, as Mani Mani intended. It seems like thefilefield wasn't getting initialized properly after a new context was created inside those statements.I ran the test suite on my non-Windows laptop and nothing broke. And I can't see any way that it could break, because some of the only other code that accesses
EvalContext'sfilefield (inIdentExpr) is commented out/useless. So, hopefully this fixes it.