Skip to content

Fix ReceiverEstimatedMaximumBitrate.String crash #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sirzooro merged 1 commit into from
Sep 22, 2026
Merged

Fix ReceiverEstimatedMaximumBitrate.String crash #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion receiver_estimated_maximum_bitrate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ func (p *ReceiverEstimatedMaximumBitrate) Header() Header {
// String prints the REMB packet in a human-readable format.
func (p *ReceiverEstimatedMaximumBitrate) String() string {
// Keep a table of powers to units for fast conversion.
bitUnits := []string{"b", "Kb", "Mb", "Gb", "Tb", "Pb", "Eb"}
bitUnits := []string{"b", "Kb", "Mb", "Gb", "Tb", "Pb", "Eb", "Zb"}

// Do some unit conversions because b/s is far too difficult to read.
bitrate := p.Bitrate
Expand Down
2 changes: 2 additions & 0 deletions receiver_estimated_maximum_bitrate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,4 +127,6 @@ func TestReceiverEstimatedMaximumBitrateOverflow(t *testing.T) {
err = packet.Unmarshal(input)
assert.NoError(err)
assert.Equal(math.Float32frombits(0x62800000), packet.Bitrate)

assert.Equal("ReceiverEstimatedMaximumBitrate 0 1.18 Zb/s", packet.String())
}
Loading