Skip to content

Allowing xtol and ftol stopping criteria in OptimisationController - #1508

Merged
MichaelClerx merged 16 commits into
mainfrom
1502-xtol-ftol
Feb 5, 2026
Merged

MichaelClerx merged 16 commits into
mainfrom
1502-xtol-ftol

Conversation

@MichaelClerx

@MichaelClerx MichaelClerx commented Nov 21, 2023 •

Copy link
Copy Markdown
Member

Closes #1502

@MichaelClerx

Copy link
Copy Markdown
Member Author

@martinjrobins @chonlei @mirams can you have a look and see if this makes sense, before I add tests?

Comment thread CHANGELOG.md Outdated
@MichaelClerx
MichaelClerx marked this pull request as ready for review January 26, 2026 15:05
@MichaelClerx
MichaelClerx marked this pull request as draft January 26, 2026 15:10
@MichaelClerx

MichaelClerx commented Jan 26, 2026 •

Copy link
Copy Markdown
Member Author

Fine, we can just go with long names

  • set_max_unchanged_function_iterations
  • set_max_unchanged_parameter_iterations
  • Make "unchanged_iterations" be a deprecated alias of unchanged_function_iterations
  • Add better tests for stopping criteria

@MichaelClerx

Copy link
Copy Markdown
Member Author

Fine, we can just go with long names

* [ ]  set_max_unchanged_function_iterations

* [ ]  set_max_unchanged_parameter_iterations

* [ ]  Make "unchanged_iterations" be a deprecated alias of unchanged_function_iterations

Going to do this next week, merge it in, and do a new release that's compatible with latest numpy #1712 unless anyone has strong objections @mirams @martinjrobins @chonlei ?

@MichaelClerx
MichaelClerx marked this pull request as ready for review February 4, 2026 22:58
@codecov

codecov Bot commented Feb 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7594349) to head (3949338).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1508   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           97        97           
  Lines         9704      9741   +37     
=========================================
+ Hits          9704      9741   +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MichaelClerx

Copy link
Copy Markdown
Member Author

@mirams @martinjrobins @chonlei last chance to object to these names and name changes! If I don't hear anything I'll merge this tomorrow evening

@MichaelClerx

MichaelClerx commented Feb 4, 2026 •

Copy link
Copy Markdown
Member Author

Some alternatives suggested here: #1678 (comment)

General vibe there: use function_tolerance and parameter_tolerance. Several upvotes. So going for that

@MichaelClerx
MichaelClerx merged commit 5873cd8 into main Feb 5, 2026
15 checks passed
@MichaelClerx
MichaelClerx deleted the 1502-xtol-ftol branch February 5, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "xtol" and "ftol" stopping criteria for optimisers

2 participants