Repository navigation
fix(release): verify imports typescript/sync, the 7.1 beta export - #108
Merged
Merged
Conversation
At pin 3e9236361fa9 (typescript@7.1.0-beta) Go's typescript package exports its API as ./sync, ./async and so on, not ./unstable/* (#64681). The release verify step and npm-alias-test.sh imported typescript/unstable/sync, so every release verify job failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
`tsc --listFilesOnly | grep -qx` failed on darwin-x64 with exit 141: grep -q ended at the first match, and the tsc died of SIGPIPE under pipefail. grep without -q reads all of the output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
t3dotgg
added a commit
that referenced
this pull request
Oct 23, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every Release
verifyjob fails on main. The step "npm install and check (@tsc-rs/typescript as typescript)" runsawait import("typescript/unstable/sync"). At our pin 3e9236361fa9 (typescript@7.1.0-beta), Go'stypescriptpackage exports its API as./sync,./async,./fsand so on. The./unstable/*names are gone (microsoft/TypeScript#64681, "[api] Prepare for beta release"). So a release from main fails at verify, as the PR #106 run showed on all 6 platforms.Fix
release.yml verify: import
typescript/sync.scripts/goport/npm-alias-test.sh: the same import and its check text.
npm/typescript-readme.md: name the new module paths.
release.yml "Check the tsc":
grep -x ... > /dev/nullin place ofgrep -qx.grep -qcan end before the tsc does, and the tsc then dies of SIGPIPE (exit 141 under pipefail). This PR's first Release run hit it on darwin-x64 (the same fix as in perf(release): faster linux-x64 tsc (memfast, BOLT) #106).The exports map itself needs no change:
npm/pack.mjscopies Go'spackage.jsonexports at the pin.This PR's Release run is the check: its
verifyjobs must pass. Nothing publishes on a pull request run.Changes by Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code