Repository navigation
sessionctx: default paging size bytes to 4 MiB - #69868
ti-chi-bot[bot] merged 4 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughThe ChangesPaging size configuration
Test sharding
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #69868 +/- ##
================================================
- Coverage 76.3193% 73.9508% -2.3686%
================================================
Files 2041 2058 +17
Lines 559929 578636 +18707
================================================
+ Hits 427334 427906 +572
- Misses 131694 150399 +18705
+ Partials 901 331 -570
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@YuhaoZhang00: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cf002db to
dfadbc8
Compare
Signed-off-by: JmPotato <github@ipotato.me>
Signed-off-by: JmPotato <github@ipotato.me>
Signed-off-by: JmPotato <github@ipotato.me>
PR pingcap#68697 added a new test function to pkg/bindinfo/tests without regenerating the Bazel metadata, which breaks check-bazel-prepare on master. Sync the shard_count to match. Signed-off-by: JmPotato <github@ipotato.me>
0eba91e to
a71ca6e
Compare
…rding - Sync the default value with pingcap/tidb#69868: 0 -> 4194304 (4 MiB) - Apply review suggestions: clarify the byte-budget paging description, note that 0 disables it, and reword the internal-variable notice Signed-off-by: JmPotato <github@ipotato.me>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xPoe, yudongusa, YuhaoZhang00 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ref pingcap#68085 (cherry picked from commit cae12c1) Signed-off-by: JmPotato <github@ipotato.me>
ref pingcap#68085 (cherry picked from commit cae12c1) Signed-off-by: JmPotato <github@ipotato.me>
What problem does this PR solve?
Issue Number: ref #68085
Problem Summary:
tidb_paging_size_bytescurrently defaults to0, leaving byte-budget paging disabled unless it is explicitly configured.Regression testing with paging enabled found no material performance regression in the tested cap-bound and under-cap TPC-C, FullScan, and Join workloads. Among the tested 1, 2, 4, 8, and 16 MiB candidates, 4 MiB had the lowest weighted score and the best overall balance across throughput, tail latency, RU stability, RPC overhead, CPU, RU efficiency, and worst-case behavior. It was not the winner of every individual metric; the recommendation is a robust default for the tested workload matrix rather than a claim of a universal optimum.
What changed and how does it work?
tidb_paging_size_bytesfrom0to 4 MiB.Setting this variable does not enable byte-budget paging for every workload. TiDB forwards the byte budget only when Resource Control is enabled and the active Resource Group is configured as non-burstable (has limited burst). Users can still explicitly set the variable to
0to disable byte-budget paging.Check List
Tests
Validated locally:
(cd tests/integrationtest && ./run-tests.sh -r sessionctx/setvar)(709 cases passed)make lintgit diff --check upstream/master...HEADSide effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Summary by CodeRabbit
tidb_paging_size_bytes, clarifying when the setting applies.SET @@tidb_paging_size_bytes=defaultso it now returns 4,194,304 instead of 0.