Repository navigation
build: resolve Bazel Go deps through GOPROXY (#69503) - #69812
ti-chi-bot wants to merge 1 commit into
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@wuhuizuo This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
🔥 Files not summarized due to errors (1)
📝 WalkthroughWalkthroughThe PR changes Bazel dependency generation to use GOPROXY-provided module metadata, removes mirror artifact upload and reuse paths, updates Makefile invocations, deprecates mirror flags and upload behavior, and adds a Bazel ABI-check target. Merge conflict markers remain in several changed regions. ChangesGOPROXY Bazel dependency flow
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This is an automated cherry-pick of #69503
Issue Number: close #69513
Summary
cmd/mirrorto generatego_repositoryentries withsumandversioninstead of mirroredurls,sha256, andstrip_prefixpingcapmirrorGo module upload path and deprecatedbazel_mirror_uploadDEPS.bzlso Bazel Go dependencies are resolved by rules_go through the configured Go module environment, e.g.GOPROXY=...|...,directTest Plan
make tidygo test ./cmd/mirrorPATH=/tmp/tidb-bazel-shim:$PATH make bazel_preparePATH=/tmp/tidb-bazel-shim:$PATH make bazel_mirror_uploadPATH=/tmp/tidb-bazel-shim:$PATH make lintgit -c core.whitespace=-tab-in-indent diff --checkDEPS.bzlhas nopingcapmirror,cache.hawkingrei.com,urls,sha256, orstrip_prefixentries for Go modulesTests
Release note
Summary by CodeRabbit