Skip to content

deps: bump pingcap base image to v1.12.3 - #7040

Open
wuhuizuo wants to merge 2 commits into
release-1.xfrom
bump-pingcap-base-v1.12.3-release-1.x
Open

deps: bump pingcap base image to v1.12.3#7040
wuhuizuo wants to merge 2 commits into
release-1.xfrom
bump-pingcap-base-v1.12.3-release-1.x

Conversation

@wuhuizuo

@wuhuizuo wuhuizuo commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Bump the ghcr.io/pingcap-qe/bases/pingcap-base base image from v1.12.2 to v1.12.3 (digest-pinned) across the five Dockerfiles that reference it. This is a routine base-image refresh, picking up the latest base image patch release.

What is changed and how does it work?

No operator code changes. Only the FROM line of five Dockerfiles is updated:

  • cmd/http-service/Dockerfile
  • images/br-federation-manager/Dockerfile
  • images/br-federation-manager/Dockerfile.e2e
  • images/tidb-operator/Dockerfile
  • images/tidb-operator/Dockerfile.e2e

The tag moves v1.12.2 -> v1.12.3 and the digest is re-pinned to the v1.12.3 manifest-list digest (sha256:eee0c7a72ce382ec2bca340c6ab4c996e56a5d9deb3745ebcbe43d65bec86b88), obtained from the ghcr.io registry (anonymous token + Docker-Content-Digest header on the manifest-list media type). This matches the digest-pinning convention used in previous bumps (#7020 / #7021).

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Local verification:

  • git diff shows exactly the five FROM lines changed, nothing else.
  • The digest matches the v1.12.3 manifest-list digest returned by the ghcr registry, and the v1.12.2 digest (0777...) previously pinned in these files matches the same query against the v1.12.2 tag, confirming the digest type is consistent.

Side effects

  • Breaking backward compatibility
  • Other side effects: base image patch release; no functional change expected. CI image builds will pull the new base layer.

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

No cherry-pick is required: counterpart PRs covering all currently maintained release branches are opened directly (release-1.6 (#7041), main (#7038), release-2.1 (#7042)).

Release Notes

Bump the pingcap base image to v1.12.3.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 90db4cd7-b9b9-4055-8b46-71ee17cd4d5f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the size/S label Aug 19, 2026
@ti-chi-bot
ti-chi-bot Bot requested a review from shonge August 19, 2026 02:26
@ti-chi-bot

ti-chi-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fengou1 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liubog2008

Copy link
Copy Markdown
Member

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-br

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants