Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 13 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… notes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fb6342e to
95cce07
Compare
What is changed, added or deleted? (Required)
In the v8.0.0 release notes, the
tidb_opt_use_invisible_indexesfeature description says:"Making the index visible first" contradicts the feature. A visible index can be selected by the optimizer in every session, so the test would affect other sessions.
tidb_opt_use_invisible_indexesexists so that an invisible index can be tested in the current session only:docs-cn,releases/release-8.0.0.md) says 「可以先将索引创建为不可见索引,然后通过修改该系统变量在当前会话中测试新索引的性能,而不影响其他会话」, that is, "first create the index as an invisible index, and then test the new index's performance in the current session by modifying the system variable, without affecting other sessions".This PR changes the sentence to "you can create a new index as an invisible index first, and then test its performance by modifying the system variable in the current session without affecting other sessions."
This was found while reviewing the Japanese translation (#24152), which mirrors the EN text. This PR targets
release-8.5so that the weekly EN→JA sync carries the fix to the Japanese docs.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code