Repository navigation
Conversation
… architectures
Render "disaggregated storage and compute architecture" as
ストレージとコンピューティングの分離アーキテクチャ and "coupled storage and
compute architecture" as ストレージとコンピューティングの結合アーキテクチャ.
The old renderings started with 分散 ("distributed"), which is a false
friend, or used several other forms.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 15 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe documentation and release notes update TiFlash architecture terminology to describe storage-compute disaggregation. Links, stated capabilities, requirements, configuration guidance, deployment constraints, and issue descriptions remain unchanged. ChangesTiFlash terminology
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: 🔵 Low · up to The page uses two Japanese names for the same default TiFlash architecture. Aligning them is a small documentation fix; the issue is limited to terminology consistency and does not change deployment behavior. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 5 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: pingcap/docs/.coderabbit.yaml
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
d791c487-225a-4a36-b7cc-17d2b7401cd2
📒 Files selected for processing (26)
TOC.mdbasic-features.mdhardware-and-software-requirements.mdreleases/release-7.0.0.mdreleases/release-7.1.0.mdreleases/release-7.1.1.mdreleases/release-7.4.0.mdreleases/release-7.5.1.mdreleases/release-7.5.2.mdreleases/release-7.5.4.mdreleases/release-7.5.5.mdreleases/release-7.5.6.mdreleases/release-7.6.0.mdreleases/release-8.0.0.mdreleases/release-8.1.0.mdreleases/release-8.1.1.mdreleases/release-8.1.2.mdreleases/release-8.2.0.mdreleases/release-8.3.0.mdreleases/release-8.4.0.mdreleases/release-8.5.0.mdreleases/release-8.5.1.mdreleases/release-8.5.2.mdreleases/release-8.5.4.mdtiflash/tiflash-configuration.mdtiflash/tiflash-disaggregated-and-s3.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
…sh disaggregated doc Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What is changed, added or deleted? (Required)
Uses one Japanese rendering for each TiFlash architecture name:
releases/release-7.6.0.md). 分散 means "distributed", so the most common rendering was a false friend. The same rendering was already used in a few places, for example thehardware-and-software-requirements.mdheading.releases/release-8.1.2.mdandreleases/release-8.4.0.md) → ストレージとコンピューティングの分離アーキテクチャにおけるリクエスト. Inrelease-8.1.2.md, the old rendering 分散ストレージリクエストとコンピューティングリクエスト also split the phrase into two kinds of requests.Small fixes on the same lines:
releases/release-7.4.0.md: the bold spanTiFlash**の…**now starts after the particle: TiFlash の**…**.releases/release-7.0.0.mdandreleases/release-7.1.0.md: removed a stray 、 at the start of the link text in the highlights table.Natural paraphrases such as ストレージとコンピューティングを分離したアーキテクチャ and ストレージとコンピューティングを組み合わせたアーキテクチャ are unchanged. Anchors, links, and configuration names are unchanged.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code
Summary by CodeRabbit