Skip to content

i18n(ja): use one rendering for the disaggregated and coupled TiFlash architectures - #24151

Open
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-disaggregated-term
Open

yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-disaggregated-term

Conversation

@yahonda

@yahonda yahonda commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Uses one Japanese rendering for each TiFlash architecture name:

  • "disaggregated storage and compute architecture" → ストレージとコンピューティングの分離アーキテクチャ. The old renderings were 分散ストレージおよびコンピューティングアーキテクチャ, 分散ストレージとコンピューティングアーキテクチャ, 分散型…, 分離型…, 分離された…, and 非集約… (releases/release-7.6.0.md). 分散 means "distributed", so the most common rendering was a false friend. The same rendering was already used in a few places, for example the hardware-and-software-requirements.md heading.
  • "coupled storage and compute architecture" → ストレージとコンピューティングの結合アーキテクチャ, which pairs with the rendering above. The old renderings were 結合(型)ストレージおよびコンピューティングアーキテクチャ and 結合されたストレージとコンピューティングアーキテクチャ.
  • "disaggregated storage and compute requests" (releases/release-8.1.2.md and releases/release-8.4.0.md) → ストレージとコンピューティングの分離アーキテクチャにおけるリクエスト. In release-8.1.2.md, the old rendering 分散ストレージリクエストとコンピューティングリクエスト also split the phrase into two kinds of requests.

Small fixes on the same lines:

  • releases/release-7.4.0.md: the bold span TiFlash**の…** now starts after the particle: TiFlash の**…**.
  • releases/release-7.0.0.md and releases/release-7.1.0.md: removed a stray 、 at the start of the link text in the highlights table.

Natural paraphrases such as ストレージとコンピューティングを分離したアーキテクチャ and ストレージとコンピューティングを組み合わせたアーキテクチャ are unchanged. Anchors, links, and configuration names are unchanged.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Standardized TiFlash’s architecture terminology across feature guides, requirements, configuration references, and release notes to describe its storage-compute disaggregation architecture.
    • Clarified references to separate write and compute nodes while keeping existing deployment requirements, limitations, and feature details unchanged.

… architectures

Render "disaggregated storage and compute architecture" as
ストレージとコンピューティングの分離アーキテクチャ and "coupled storage and
compute architecture" as ストレージとコンピューティングの結合アーキテクチャ.
The old renderings started with 分散 ("distributed"), which is a false
friend, or used several other forms.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ti-chi-bot

ti-chi-bot Bot commented Oct 6, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lance6716 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 6, 2026
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 15 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: pingcap/docs/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 91a411f7-4ed6-4550-bd0c-215fb851fed9
📥 Commits

Reviewing files that changed from the base of the PR and between 4b1b1cd and fc2e015.

📒 Files selected for processing (1)
  • tiflash/tiflash-disaggregated-and-s3.md
📝 Walkthrough

Walkthrough

The documentation and release notes update TiFlash architecture terminology to describe storage-compute disaggregation. Links, stated capabilities, requirements, configuration guidance, deployment constraints, and issue descriptions remain unchanged.

Changes

TiFlash terminology

Layer / File(s) Summary
Architecture reference terminology
TOC.md, basic-features.md, hardware-and-software-requirements.md, tiflash/tiflash-configuration.md, tiflash/tiflash-disaggregated-and-s3.md
The architecture references and guidance use updated terminology for storage-compute disaggregation. Links, requirements, configuration scope, and deployment guidance remain unchanged.
Release-note terminology
releases/release-*.md
TiFlash feature descriptions and historical improvement and bug-fix entries use updated architecture terminology. The reported issues and described capabilities remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: qiancai

Merge Risk: 🔵 Low · up to 4b1b1

The page uses two Japanese names for the same default TiFlash architecture. Aligning them is a small documentation fix; the issue is limited to terminology consistency and does not change deployment behavior.

Architecture Summary

Architecture risk: 🔵 Low · up to 4b1b1

The change affects 5 systems.

Changed systems: releases, tiflash, basic-features.md, hardware-and-software-requirements.md, TOC.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — releases (service) was modified; 21 changed files map to changed impact.
  • observed — tiflash (service) was modified; 2 changed files map to changed impact.
  • observed — basic-features.md (service) was modified; 1 changed file maps to changed impact.
  • observed — hardware-and-software-requirements.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in TOC.md: TiFlashの目次項目名を変更し、リンク先は維持しました。
  • observed — Modified behavior in basic-features.md: Renamed the TiFlash feature description from “distributed storage and computing architecture” to “storage and computing separation architecture”; the linked page and support statuses for versions 8.5 through 5.4 are unchanged.
  • observed — Modified behavior in hardware-and-software-requirements.md: The section heading and prose replace “separated/distributed” terminology with “disaggregated” or “storage and compute separation.” The description still states that TiFlash supports the architecture from v7.0.0 and splits into write and compute nodes; the software and network requirements remain the same as for the combined architecture.
  • observed — Modified behavior in releases/release-7.0.0.md: The TiFlash feature table and scalability entry now describe the architectures as storage-compute disaggregated and storage-compute coupled, replacing the previous distributed/separated terminology. The S3-compatible object storage description and the restriction against mixing or converting architectures within a cluster remain.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: standardizing Japanese names for TiFlash’s disaggregated and coupled architectures.
Description check ✅ Passed The description explains the terminology changes, related wording fixes, and rationale. It also identifies the affected documentation version and notes AI involvement. The related-link fields are blan…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Repository: pingcap/docs/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d791c487-225a-4a36-b7cc-17d2b7401cd2
📥 Commits

Reviewing files that changed from the base of the PR and between a4dfec7 and 4b1b1cd.

📒 Files selected for processing (26)
  • TOC.md
  • basic-features.md
  • hardware-and-software-requirements.md
  • releases/release-7.0.0.md
  • releases/release-7.1.0.md
  • releases/release-7.1.1.md
  • releases/release-7.4.0.md
  • releases/release-7.5.1.md
  • releases/release-7.5.2.md
  • releases/release-7.5.4.md
  • releases/release-7.5.5.md
  • releases/release-7.5.6.md
  • releases/release-7.6.0.md
  • releases/release-8.0.0.md
  • releases/release-8.1.0.md
  • releases/release-8.1.1.md
  • releases/release-8.1.2.md
  • releases/release-8.2.0.md
  • releases/release-8.3.0.md
  • releases/release-8.4.0.md
  • releases/release-8.5.0.md
  • releases/release-8.5.1.md
  • releases/release-8.5.2.md
  • releases/release-8.5.4.md
  • tiflash/tiflash-configuration.md
  • tiflash/tiflash-disaggregated-and-s3.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread tiflash/tiflash-disaggregated-and-s3.md Outdated
…sh disaggregated doc

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant