fix(security): bump deps + Go 1.25 to clear dms binary CVEs - #13
Closed
just1900 wants to merge 1 commit into
Closed
Conversation
- prometheus/alertmanager 0.21.0->0.33.1, client_golang 1.7.1->1.24.1 - google.golang.org/protobuf 1.23.0->1.36.11, golang.org/x/sys latest - go directive ->1.25, pin builder golang:1.25-alpine (Go 1.25.12 stdlib) Verified trivy-clean (0 CRITICAL/HIGH/MEDIUM) for the dms binary (scratch base). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the project’s Go toolchain and Go module dependencies to remediate CVEs in the built dms binary and align the build container with the targeted Go release.
Changes:
- Updated
go.modto Go 1.25 and bumped Prometheus/Protobuf-related dependencies. - Regenerated
go.sumto match the new module graph. - Updated the builder base image to
golang:1.25-alpine.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go.mod | Bumps Go version directive and key dependencies (Prometheus, protobuf, yaml) and records indirect deps. |
| go.sum | Refreshes dependency checksums after the module upgrades/tidy. |
| build/Dockerfile | Pins the builder image to Go 1.25 (Alpine) for the rebuild. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| module github.com/pingcap/dead-mans-switch | ||
|
|
||
| go 1.14 | ||
| go 1.25.0 |
| @@ -1,4 +1,4 @@ | |||
| FROM golang:alpine as builder | |||
| FROM golang:1.25-alpine as builder | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilds the dead-man's-switch (dms) binary trivy-clean.
Bumps (all in go.mod):
golang:1.25-alpine(Go 1.25.12 stdlib)Verified with trivy (
--severity CRITICAL,HIGH,MEDIUM): 0/0/0 for the dms binary (scratch runtime, no OS packages).Image pushed to prod ECR:
557537366020.dkr.ecr.us-west-2.amazonaws.com/deadmanswatch:v1.0.2-3b4b56a.Part of the O11y first-party image security remediation.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com