Skip to content

Add getCalculatedFieldValue and getCalculatedFieldValueForEditMode #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martineiber merged 2 commits into from
Apr 21, 2026
Merged

Add getCalculatedFieldValue and getCalculatedFieldValueForEditMode #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09330f6
Add getCalculatedFieldValue and getCalculatedFieldValueForEditMode
martineiber Apr 20, 2026
69fb985
Merge remote-tracking branch 'origin/3.6' into add-missing-calculatio…
martineiber Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/Models/DataObject/DataObjectServiceResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@
use Pimcore\Model\DataObject\ClassDefinition;
use Pimcore\Model\DataObject\ClassDefinition\Data;
use Pimcore\Model\DataObject\Concrete;
use Pimcore\Model\DataObject\Data\CalculatedValue;
use Pimcore\Model\DataObject\Fieldcollection\Data\AbstractData as FieldCollectionData;
use Pimcore\Model\DataObject\Objectbrick\Data\AbstractData as ObjectbrickData;
use Pimcore\Model\DataObject\Service;
use Pimcore\Model\DataObject\Service as PimcoreDataObjectService;
use Pimcore\Model\User;

/**
Expand Down Expand Up @@ -50,4 +54,19 @@
): void {
Service::enrichLayoutPermissions($layout, $allowedView, $allowedEdit, $user);
}

public function getCalculatedFieldValue(
FieldCollectionData|ObjectbrickData|Concrete $object,
?CalculatedValue $data,
): mixed {
return PimcoreDataObjectService::getCalculatedFieldValue($object, $data);

Check warning on line 62 in src/Models/DataObject/DataObjectServiceResolver.php

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/Models/DataObject/DataObjectServiceResolver.php#L62 

Avoid using static access to class '\Pimcore\Model\DataObject\Service' in method 'getCalculatedFieldValue'.
}

public function getCalculatedFieldValueForEditMode(
Concrete $object,
array $params,
?CalculatedValue $data,
): ?string {
return PimcoreDataObjectService::getCalculatedFieldValueForEditMode($object, $params, $data);

Check warning on line 70 in src/Models/DataObject/DataObjectServiceResolver.php

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/Models/DataObject/DataObjectServiceResolver.php#L70 

Avoid using static access to class '\Pimcore\Model\DataObject\Service' in method 'getCalculatedFieldValueForEditMode'.
}
}
15 changes: 15 additions & 0 deletions src/Models/DataObject/DataObjectServiceResolverInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
use Pimcore\Model\DataObject\ClassDefinition;
use Pimcore\Model\DataObject\ClassDefinition\Data;
use Pimcore\Model\DataObject\Concrete;
use Pimcore\Model\DataObject\Data\CalculatedValue;
use Pimcore\Model\DataObject\Fieldcollection\Data\AbstractData as FieldCollectionData;
use Pimcore\Model\DataObject\Objectbrick\Data\AbstractData as ObjectbrickData;
use Pimcore\Model\User;

/**
Expand All @@ -43,4 +46,16 @@
array $allowedEdit,
?User $user = null
): void;


public function getCalculatedFieldValue(
FieldCollectionData|ObjectbrickData|Concrete $object,
?CalculatedValue $data,
): mixed;

Check notice on line 54 in src/Models/DataObject/DataObjectServiceResolverInterface.php

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/Models/DataObject/DataObjectServiceResolverInterface.php#L54 

Expected 2 blank lines after function; 1 found

public function getCalculatedFieldValueForEditMode(

Check notice on line 56 in src/Models/DataObject/DataObjectServiceResolverInterface.php

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/Models/DataObject/DataObjectServiceResolverInterface.php#L56 

Expected 2 blank lines before function; 1 found
Concrete $object,
array $params,
?CalculatedValue $data,
): ?string;

Check notice on line 60 in src/Models/DataObject/DataObjectServiceResolverInterface.php

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/Models/DataObject/DataObjectServiceResolverInterface.php#L60 

Expected 2 blank lines after function; 0 found
}
Loading