Repository navigation
install.sh: remove managed-node adoption - #51
Merged
Merged
Conversation
The hosted control plane has been retired, so the installer no longer offers --managed-url / PILOT_MANAGEMENT_URL / --no-start: no enrollment token handling, no managed-runtime manifest or tag, no `pilotctl enterprise adopt`, and no updater pinning for managed nodes. `--managed-url` is now an unknown flag. Every remaining code path is the one the installer already took when managed mode was off. tests/managed-install.sh is removed with the feature. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hosted control plane has been retired (the
platformrepo is archived). This removes managed-node adoption from the canonical installer.Removed
--managed-url/--management-url/PILOT_MANAGEMENT_URLand--no-start.--managed-urlis now rejected as an unknown flag.managed-runtime-v*tag validation, thepilotctl enterprise adoptprobe and call, the machine-wide collision check that guarded adoption, updater pinning for managed nodes, and the managed summary.tests/managed-install.sh.Every remaining path is the one the installer already took with managed mode off: each
PILOT_MANAGED_MODE != 1condition was unwrapped and each= 1block deleted.Verification
sh -n,dash -n,bash -npass.tests/proxy-transport-install.shgives the same result as onmain. On macOS both stop at case 10a ("macOS: no condition next to the LaunchAgent start line"), which already fails onmainthere; with that assertion skipped both stop at the same next macOS case. I did not run the suite on Linux.pilotctl enterpriseand carries the sameinstall.sh.🤖 Generated with Claude Code