Skip to content

Update .github/scripts dependencies - #6847

Merged
ondrejmirtes merged 5 commits into
2.3.xfrom
update-github-scripts
Oct 26, 2026
Merged

ondrejmirtes merged 5 commits into
2.3.xfrom
update-github-scripts

Conversation

@ondrejmirtes

Copy link
Copy Markdown
Member

Updates the TypeScript helper that the "Download base SHA PHAR" job compiles (npx tsc) and runs through actions/github-script, one commit per step:

  1. Latest minor and patch versions
  2. Node 24 for the compile step, with @types/node 24. Node 20 reached end of life in April 2026.
  3. TypeScript 6. It deprecates the node10 module resolution that "module": "CommonJS" implies, so the config now uses "module": "nodenext", which emits the same CommonJS for this package.
  4. TypeScript 7
  5. @actions/core 3 and @actions/github 9. They are ESM-only, but the script imports them only for types, so the imports are erased from the CommonJS output. I checked that the types really resolve: a deliberate string→number mistake on context.repo.owner is reported.

Verification: after every step, dist/find-artifact.js is byte-identical to the TypeScript 5 output. A local harness that calls it the way actions/github-script does, with a real Octokit, finds the phar-file-checksum artifact of the Compile PHAR run for 7d3ede5. The "Download base SHA PHAR" job on this PR runs the same thing in CI.

Supersedes the .github/scripts part of #3443.

@ondrejmirtes
ondrejmirtes force-pushed the update-github-scripts branch from dea4dd2 to 65eed71 Compare October 26, 2026 07:09
@ondrejmirtes
ondrejmirtes force-pushed the update-github-scripts branch from 65eed71 to 3b4d70e Compare October 26, 2026 07:15
@ondrejmirtes
ondrejmirtes merged commit 48ddaa1 into 2.3.x Oct 26, 2026
925 of 926 checks passed
@ondrejmirtes
ondrejmirtes deleted the update-github-scripts branch October 26, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant