Repository navigation
Update changelog-generator dependencies - #6845
Merged
Merged
Conversation
run.php also required the root vendor/autoload.php. That autoloader is prepended, so symfony/console and guzzlehttp/guzzle were loaded from phpstan-src's own vendor directory instead of the versions in changelog-generator/composer.lock. The generator does not use anything else from the root vendor directory. Amp-Thread-ID: https://ampcode.com/threads/T-01a176c6-528a-7430-b296-e66930d153b4
http-interop/http-factory-guzzle does not allow guzzlehttp/psr7 3. It is not needed: php-http/discovery finds the PSR-17 factories in guzzlehttp/psr7 itself. Amp-Thread-ID: https://ampcode.com/threads/T-01a176c6-528a-7430-b296-e66930d153b4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates changelog-generator dependencies in small steps, one commit per step:
vendor/autoload.phpinrun.php. That autoloader is prepended, sosymfony/consoleandguzzlehttp/guzzlewere loaded from phpstan-src's own vendor directory (Console 5.4, Guzzle 7.15), not fromchangelog-generator/composer.lock. Without this, the updates below would have no effect at runtime.intreturn typeCommand::execute()now declares and replaces the deprecatedApplication::add()withaddCommand()http-interop/http-factory-guzzle, which does not allow guzzlehttp/psr7 3. php-http/discovery now findsGuzzleHttp\Psr7\HttpFactoryandGuzzleHttp\Client.Verification: after every step I generated the changelog for the last 6 commits of 2.3.x against the real GitHub API (
php run.php 7d3ede5c3~6 7d3ede5c3). The output was identical to the output before any change.--include-headingsstill prints the headings.../bin/phpstanreports no errors after every step.Supersedes #6734 and the changelog-generator part of #5920.