Repository navigation
enum::from() takes BackedEnum types into account - #6790
Merged
Merged
Conversation
StringBackedEnum in to account
AJenbo
changed the title
staabm
approved these changes
Oct 23, 2026
Contributor
There was a problem hiding this comment.
I have a feeling we did a similar thing recently with from or tryFrom, but I cannot find it anymore.
//cc @SanderMuller
LGTM
Member
|
Thank you! |
Contributor
Author
|
Just helping my self here :) |
Contributor
And others! |
Member
|
FYI doing this for bleeding edge only: #6795 Narrowing parameter types falls under "new rules" in my eyes, people might have too-wide types somewhere in a completely harmless situation. We're typically doing the same when updating signatures in functionMap too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#11421