Repository navigation
Update fidry/cpu-core-counter - #6620
Merged
Merged
Conversation
theofidry
approved these changes
Sep 28, 2026
AJenbo
force-pushed
the
cpu-core-counter
branch
from
October 23, 2026 14:22
1571cfc to
26202d9
Compare
Contributor
Author
|
@staabm I think including this in the current release cycle would be a good fit. |
staabm
reviewed
Oct 23, 2026
Comment on lines
+37
to
+40
| // lists every limit the counter looks at, also one that is overridden by the limit found before it | ||
| $output->writeLineFormatted('<info>CPU core limit:</info>'); | ||
| $output->writeRaw(Diagnoser::diagnose([$this->cpuCoreCounter->getCountLimitFinder()])); | ||
| $output->writeLineFormatted(''); |
Contributor
There was a problem hiding this comment.
tested the output with this PR:
➜ phpstan-src git:(pr/6620) php bin/phpstan diagnose -vvv
Note: Using configuration file /Users/m.staab/dvl/phpstan-src/phpstan.neon.dist.
PHP runtime version: 8.5.11
PHP composer.json required version: 8.2-8.6.99
PHP version for analysis: 8.5.11 (from config)
PHPStan version: 2.2.x-dev@1571cfc
PHPStan running from:
bin/phpstan
Extension installer: Not installed
Included configs from Composer packages:
phpstan/phpstan-deprecation-rules (rules.neon): 2.0.4
phpstan/phpstan-nette (extension.neon): 2.0.11
phpstan/phpstan-nette (rules.neon): 2.0.11
phpstan/phpstan-phpunit (extension.neon): 2.0.x-dev
phpstan/phpstan-phpunit (rules.neon): 2.0.x-dev
phpstan/phpstan-strict-rules (rules.neon): 2.0.10
shipmonk/dead-code-detector (rules.neon): 1.0.0
Discovered Composer project root:
/Users/m.staab/dvl/phpstan-src
Parallel worker creation:
Mechanism: fork (pcntl_fork)
Turbo extension: not loaded
Turbo platform: macos-arm64 (os: Darwin, machine: arm64, libc: gnu, php: 8.5, zts: no, debug: no)
Turbo worker binary: none found
Turbo trusted types: off (extension inactive)
System resources:
Detected CPU cores: 14
Load limit: 1
cgroup CPU quota: none
KUBERNETES_CPU_LIMIT: none
Usable CPU cores: 14
I think it looks good
Contributor
There was a problem hiding this comment.
comparing this PR diagnose with master I see "Avaiable after limits" is no longer available, which I think is expected, correct @AJenbo ?
Member
There was a problem hiding this comment.
I'm merging this. Feel free to send a follow-up.
Contributor
Author
There was a problem hiding this comment.
Yes, that’s expected. The relevant cap is applied internally to the lib so we can't really show the this info. Not a problem I think.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates fidry/cpu-core-counter to 1.4 which added support for cgroups and lets us simplify CPU detection.