Repository navigation
Lexer: read underscore in a tag name - #330
Merged
Merged
Conversation
ondrejmirtes
force-pushed
the
underscore-in-tag-name
branch
2 times, most recently
from
October 26, 2026 19:34
b27c9aa to
1ec0850
Compare
The lexer read @Foo_Bar as the tag @foo and the text _Bar. A Doctrine annotation class name can contain an underscore, e.g. @Foo_Bar(1). Amp-Thread-ID: https://ampcode.com/threads/T-01a17930-0285-73c5-a957-4325c77aa1b2
ondrejmirtes
force-pushed
the
underscore-in-tag-name
branch
from
October 26, 2026 20:17
1ec0850 to
5068a3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lexer read
@Foo_Baras the tag@Fooand the text_Bar. A Doctrine annotation class name can contain an underscore, e.g.@Foo_Bar(1).TOKEN_DOCTRINE_TAGalready accepts an underscore, butTOKEN_PHPDOC_TAGmatches first.This PR adds
_to the tag name characters inLexerand indoc/grammars/lexemes.pp3. The namespace prefix (@foo:) does not change.Rector has a workaround for this in its parser. With this change, the workaround can be removed.
Checks: tests on PHP 8.4 and 7.4, PHPStan, phpcs, the test suite of slevomat/coding-standard and the test suite of rector-src with this lexer.