Repository navigation
Printer: put back asterisks in multi-line texts and descriptions - #328
Merged
ondrejmirtes merged 1 commit intoOct 26, 2026
Merged
Conversation
ondrejmirtes
force-pushed
the
multiline-description-asterisks
branch
from
October 26, 2026 18:14
7589ee8 to
e3fbd5d
Compare
The parser removes the asterisk at the start of each line of a text or description. When the printer printed such a node, the lines after the first had no asterisk. The format-preserving printer now uses the line start of the original PHPDoc, so the indentation stays the same. Amp-Thread-ID: https://ampcode.com/threads/T-01a17930-0285-73c5-a957-4325c77aa1b2
ondrejmirtes
force-pushed
the
multiline-description-asterisks
branch
from
October 26, 2026 19:34
e3fbd5d to
ec9542a
Compare
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser removes
*at the start of each line of a text or description:gives
PhpDocTextNode('First line' . "\n" . 'second line'). The printer did not put the*back, so it printed a broken PHPDoc:This occurred in
print()and inprintFormatPreserving()when a node with a multi-line text or description was printed again, e.g. after a change to a@paramwith a multi-line description.Now the printer writes the line start after each newline.
printFormatPreserving()uses the line start of the original PHPDoc, so the indentation stays the same:An empty line gets
*without a space after it.