Repository navigation
Conversation
Keep an identical typed constant as the result of assignment cleanup branches instead of creating a PHI and a CV-bound COPY. A movable COPY can otherwise spill the constant into the CV before the assignment's guard, overwriting a value that the trace still needs. Add the original constant-assignment regression from phpGH-24683. Refs phpGH-24683.
Give pure-expression CV assignments their own hard COPY, including when the existing conflict check rejects a binding. A later assignment must not overwrite storage still needed by a reusable expression. After optimized liveness and coalescing, share a checked bound COPY's spill slot only when adjacent definitions have compatible types, the COPY's ranges cover every later source range, neither interval was coalesced or live before its definition, and no snapshot names the source. Keep separate value identities and private source spills otherwise. This avoids exhausting the fixed trace spill frame in safe reuse cases. Add the original two-file C reproduction, a natural floating-point CSE regression, and a test requiring successful compilation under pressure. Refs phpGH-24683.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test PR