Repository navigation
Conversation
Contributor
Author
|
The LINUX_X32_DEBUG_ZTS failure is a timeout in ext/pcntl/tests/002.phpt, which this change does not touch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a lazy ghost finishes initializing,
zend_lazy_object_init()deletes its info entry, and that is where the initializer gets released. The hash removes the entry before running its destructor, so any destructor fired by releasing the initializer (here agc_collect_cycles()in the initializer's__destruct) no longer sees the stale info and is allowed to callresetAsLazyGhost()on the object.zend_lazy_object_init()then returns an object that is lazy again, andzend_lazy_object_get_properties()asserts.ReflectionClass::markLazyObjectAsInitialized()has the same problem and ends up returning without a value or an exception.The fix releases the initializer before the info entry is deleted in both places, so a reset at that point throws "Can not reset an object while it is being initialized", the same as during the initializer call. Lazy proxies already release their initializer this way.
Fixes #24715