Repository navigation
Conversation
…he preload Co-authored-by: sanklamm <4759687+sanklamm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zend_do_traits_constant_binding()copies the trait constant into the using class but doesn't take a reference on its type, so both constants share the same class name string. During preload that string isn't interned yet, and when opcache interns it for the first constant it frees the original while the second still points to it. Now the copy goes throughzend_type_copy_ctor(), same as the trait property path. A union type also shared the type list, which trips an assertion in debug builds, so the test covers both.Based on the reporter's suggested fix.
Fixes #24701