Repository navigation
Conversation
And use the new type to improve clarity rather than just a uint8_t
github-actions
Bot
added
Category: Engine
Extension: opcache
Category: Optimizer
ABI break
labels
TimWolla
reviewed
Oct 25, 2026
Comment on lines
+154
to
+156
| zend_operand_type op1_type; /* IS_UNUSED, IS_CONST, IS_TMP_VAR, IS_VAR, IS_CV */ | ||
| zend_operand_type op2_type; /* IS_UNUSED, IS_CONST, IS_TMP_VAR, IS_VAR, IS_CV */ | ||
| zend_operand_type result_type; /* IS_UNUSED, IS_CONST, IS_TMP_VAR, IS_VAR, IS_CV */ |
Member
|
Want a hack to get rid of the warnings? #define IS_UNUSED IS_UNUSED
#define IS_CONST IS_CONST
#define IS_TMP_VAR IS_TMP_VAR
#define IS_VAR IS_VAR
#define IS_CV IS_CVput this after the enum definition. Anyway, is it worth it doing these (=this PR) kinds of changes? It takes reviewer effort to check for correctness and debugging effort to resolve issues like the warnings from CI. For me, the code was already clear in the expectation of what is allowed to be passed tbh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.