Skip to content

Fix GH-24170: read concatenated bzip2 streams - #24690

Open
kairosci wants to merge 1 commit into
php:masterfrom
kairosci:fix/gh-24170-bzip2-concatenated-streams
Open

kairosci wants to merge 1 commit into
php:masterfrom
kairosci:fix/gh-24170-bzip2-concatenated-streams

Conversation

@kairosci

Copy link
Copy Markdown
Contributor

Fixes #24170 by reading concatenated bzip2 members in the stream wrapper and bzopen(), while preserving the exported API and trailing-data behavior.

Adds regression coverage; bzip2 tests pass in debug ZTS and ASan/UBSan builds with applicable skips.

@kairosci

Copy link
Copy Markdown
Contributor Author

The macOS job fails during compilation because OpenSSL 4.1 deprecates ASN1_STRING_set() and ASN1_STRING_length(), and deprecation warnings are treated as errors. Tests never start. This is unrelated to the bzip2 changes and is already addressed separately by #24686.

Failing job: https://github.com/php/php-src/actions/runs/40205742173/job/121206203893

@kairosci

Copy link
Copy Markdown
Contributor Author

@ndossche as soon as you can, could you take a look at it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bzip2.decompress stream wrapper truncates valid bz2 files from pbzip2

1 participant