Repository navigation
Conversation
ndossche
reviewed
Oct 24, 2026
| /* }}} */ | ||
|
|
||
| /* {{{ php_date_set_tzdb - NOT THREADSAFE */ | ||
| PHPAPI void php_date_set_tzdb(timelib_tzdb *tzdb) |
Member
There was a problem hiding this comment.
You can't drop this, this is used in a popular PIE/PECL extension for updating the timezone database independently from PHP
Member
Author
There was a problem hiding this comment.
Okay so even SourceGraph is useless now to check stuff.
Member
There was a problem hiding this comment.
I think SourceGraph was always best-effort without guarantees.
Anyway the package is https://github.com/php/pecl-datetime-timezonedb/blob/master/timezonedb.c, maintained by Derick
Girgias
force-pushed
the
2026-10-date-api-drop
branch
from
October 25, 2026 15:52
453f12b to
edaa439
Compare
github-actions
Bot
added
Category: Engine
Extension: opcache
Category: Optimizer
labels
Girgias
force-pushed
the
2026-10-date-api-drop
branch
from
October 25, 2026 16:52
a321bc9 to
edaa439
Compare
Girgias
marked this pull request as ready for review
October 26, 2026 14:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effectively making unused APIs private and no longer exposed in the header.
Commits should be reviewed individually.