Skip to content

Fix GH-24579: Crash in FILTER_VALIDATE_INT when __toString() mutates the options #24580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bercedev wants to merge 2 commits into
base: PHP-8.4
Choose a base branch
from
+58 −5
Open

Fix GH-24579: Crash in FILTER_VALIDATE_INT when __toString() mutates the options #24580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7f5888
Fix GH-24579: Crash in FILTER_VALIDATE_INT when __toString() mutates …
bercedev Oct 22, 2026
491341b
Test that the options as passed are the ones used
bercedev Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions ext/filter/filter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,8 +485,11 @@ static void php_filter_call(
) /* {{{ */ {
zval *options = NULL;
zval *option;
zval options_copy;
char *charset = NULL;

ZVAL_UNDEF(&options_copy);

if (!filter_args_ht) {
if (filter != -1) { /* handler for array apply */
/* filter_args is the filter_flags */
Expand All @@ -504,12 +507,16 @@ static void php_filter_call(
}

if ((option = zend_hash_str_find_deref(filter_args_ht, "options", sizeof("options") - 1)) != NULL) {
/* Hold our own copy: converting the value to a string can run __toString(),
* which may change the options through a reference (GH-24579). */
if (filter != FILTER_CALLBACK) {
if (Z_TYPE_P(option) == IS_ARRAY) {
options = option;
ZVAL_COPY(&options_copy, option);
options = &options_copy;
}
} else {
options = option;
ZVAL_COPY(&options_copy, option);
options = &options_copy;
filter_flags = 0;
}
}
Expand All @@ -531,10 +538,10 @@ static void php_filter_call(
} else {
ZVAL_FALSE(filtered);
}
return;
goto out;
}
php_zval_filter_recursive(filtered, filter, filter_flags, options, charset, copy);
return;
goto out;
}
if (filter_flags & FILTER_REQUIRE_ARRAY) {
zval_ptr_dtor(filtered);
Expand All @@ -543,7 +550,7 @@ static void php_filter_call(
} else {
ZVAL_FALSE(filtered);
}
return;
goto out;
}

php_zval_filter(filtered, filter, filter_flags, options, charset, copy);
Expand All @@ -553,6 +560,9 @@ static void php_filter_call(
array_init(filtered);
add_next_index_zval(filtered, &tmp);
}

out:
zval_ptr_dtor(&options_copy);
}
/* }}} */

Expand Down
43 changes: 43 additions & 0 deletions ext/filter/tests/gh24579.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
--TEST--
GH-24579 (Crash in FILTER_VALIDATE_INT when __toString() mutates the referenced options array)
--EXTENSIONS--
filter
--FILE--
<?php

$shared = ['min_range' => 0];
$args = ['options' => &$shared];

class Reenter
{
public function __toString(): string
{
global $shared;
$shared = 'changed';
return '1';
}
}

var_dump(filter_var(new Reenter(), FILTER_VALIDATE_INT, $args));
var_dump($shared);

// The options in effect are the ones passed in, not what __toString() leaves behind.
$shared = ['min_range' => 0];

class Swap
{
public function __toString(): string
{
global $shared;
$shared = ['min_range' => 5];
return '1';
}
}

var_dump(filter_var(new Swap(), FILTER_VALIDATE_INT, $args));

?>
--EXPECT--
int(1)
string(7) "changed"
int(1)
Loading